Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2787713004: MD Settings: Make password dialog inputs appear read-only (Closed)

Created:
3 years, 8 months ago by scottchen
Modified:
3 years, 8 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make password dialog inputs appear read-only BUG=703979 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2787713004 Cr-Commit-Position: refs/heads/master@{#461252} Committed: https://chromium.googlesource.com/chromium/src/+/101df2078bd35882ebd8e52d3b0fb7a0b6bf6ea8

Patch Set 1 #

Patch Set 2 : restyle readonly textfields in password dialog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 1 2 chunks +21 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
scottchen
3 years, 8 months ago (2017-03-31 00:01:41 UTC) #3
dschuyler
lgtm
3 years, 8 months ago (2017-03-31 01:07:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787713004/20001
3 years, 8 months ago (2017-03-31 20:21:21 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 22:23:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/101df2078bd35882ebd8e52d3b0f...

Powered by Google App Engine
This is Rietveld 408576698