Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: media/capture/video/video_capture_system_impl.h

Issue 2787703004: [Mojo Video Capture] Fix VideoCaptureManager exposing implementation details to clients (Closed)
Patch Set: Rebase to April 5 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/capture/video/video_capture_system.cc ('k') | media/capture/video/video_capture_system_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/capture/video/video_capture_system_impl.h
diff --git a/media/capture/video/video_capture_system.h b/media/capture/video/video_capture_system_impl.h
similarity index 54%
copy from media/capture/video/video_capture_system.h
copy to media/capture/video/video_capture_system_impl.h
index f03e3a98236e5d9d47e2f2c91a0341a59da27c12..97cfc697f46451200d927c3f959d211db5461173 100644
--- a/media/capture/video/video_capture_system.h
+++ b/media/capture/video/video_capture_system_impl.h
@@ -2,39 +2,25 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_H_
-#define MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_H_
+#ifndef MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_IMPL_H_
+#define MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_IMPL_H_
-#include "media/capture/video/video_capture_device_factory.h"
-#include "media/capture/video/video_capture_device_info.h"
+#include "media/capture/video/video_capture_system.h"
namespace media {
// Layer on top of VideoCaptureDeviceFactory that translates device descriptors
// to string identifiers and consolidates and caches device descriptors and
// supported formats into VideoCaptureDeviceInfos.
-class CAPTURE_EXPORT VideoCaptureSystem {
+class CAPTURE_EXPORT VideoCaptureSystemImpl : public VideoCaptureSystem {
public:
- using DeviceInfoCallback =
- base::Callback<void(const std::vector<VideoCaptureDeviceInfo>&)>;
-
- explicit VideoCaptureSystem(
+ explicit VideoCaptureSystemImpl(
std::unique_ptr<VideoCaptureDeviceFactory> factory);
- ~VideoCaptureSystem();
-
- // The passed-in |result_callback| must have ownership of the called
- // VideoCaptureSystem instance to guarantee that it stays alive during the
- // asynchronous operation.
- void GetDeviceInfosAsync(const DeviceInfoCallback& result_callback);
+ ~VideoCaptureSystemImpl() override;
- // Creates a VideoCaptureDevice object. Returns nullptr if something goes
- // wrong.
+ void GetDeviceInfosAsync(const DeviceInfoCallback& result_callback) override;
std::unique_ptr<VideoCaptureDevice> CreateDevice(
- const std::string& device_id);
-
- media::VideoCaptureDeviceFactory* video_capture_device_factory() const {
- return factory_.get();
- }
+ const std::string& device_id) override;
private:
void OnDescriptorsReceived(
@@ -53,4 +39,4 @@ class CAPTURE_EXPORT VideoCaptureSystem {
} // namespace media
-#endif // MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_DEVICE_FACTORY_H_
+#endif // MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_IMPL_H_
« no previous file with comments | « media/capture/video/video_capture_system.cc ('k') | media/capture/video/video_capture_system_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698