Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: media/capture/video/video_capture_system_impl.h

Issue 2787703004: [Mojo Video Capture] Fix VideoCaptureManager exposing implementation details to clients (Closed)
Patch Set: Rebase to April 5 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_H_ 5 #ifndef MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_IMPL_H_
6 #define MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_H_ 6 #define MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_IMPL_H_
7 7
8 #include "media/capture/video/video_capture_device_factory.h" 8 #include "media/capture/video/video_capture_system.h"
9 #include "media/capture/video/video_capture_device_info.h"
10 9
11 namespace media { 10 namespace media {
12 11
13 // Layer on top of VideoCaptureDeviceFactory that translates device descriptors 12 // Layer on top of VideoCaptureDeviceFactory that translates device descriptors
14 // to string identifiers and consolidates and caches device descriptors and 13 // to string identifiers and consolidates and caches device descriptors and
15 // supported formats into VideoCaptureDeviceInfos. 14 // supported formats into VideoCaptureDeviceInfos.
16 class CAPTURE_EXPORT VideoCaptureSystem { 15 class CAPTURE_EXPORT VideoCaptureSystemImpl : public VideoCaptureSystem {
17 public: 16 public:
18 using DeviceInfoCallback = 17 explicit VideoCaptureSystemImpl(
19 base::Callback<void(const std::vector<VideoCaptureDeviceInfo>&)>; 18 std::unique_ptr<VideoCaptureDeviceFactory> factory);
19 ~VideoCaptureSystemImpl() override;
20 20
21 explicit VideoCaptureSystem( 21 void GetDeviceInfosAsync(const DeviceInfoCallback& result_callback) override;
22 std::unique_ptr<VideoCaptureDeviceFactory> factory);
23 ~VideoCaptureSystem();
24
25 // The passed-in |result_callback| must have ownership of the called
26 // VideoCaptureSystem instance to guarantee that it stays alive during the
27 // asynchronous operation.
28 void GetDeviceInfosAsync(const DeviceInfoCallback& result_callback);
29
30 // Creates a VideoCaptureDevice object. Returns nullptr if something goes
31 // wrong.
32 std::unique_ptr<VideoCaptureDevice> CreateDevice( 22 std::unique_ptr<VideoCaptureDevice> CreateDevice(
33 const std::string& device_id); 23 const std::string& device_id) override;
34
35 media::VideoCaptureDeviceFactory* video_capture_device_factory() const {
36 return factory_.get();
37 }
38 24
39 private: 25 private:
40 void OnDescriptorsReceived( 26 void OnDescriptorsReceived(
41 const DeviceInfoCallback& result_callback, 27 const DeviceInfoCallback& result_callback,
42 std::unique_ptr<VideoCaptureDeviceDescriptors> descriptors); 28 std::unique_ptr<VideoCaptureDeviceDescriptors> descriptors);
43 29
44 // Returns nullptr if no descriptor found. 30 // Returns nullptr if no descriptor found.
45 const VideoCaptureDeviceInfo* LookupDeviceInfoFromId( 31 const VideoCaptureDeviceInfo* LookupDeviceInfoFromId(
46 const std::string& device_id); 32 const std::string& device_id);
47 33
48 const std::unique_ptr<VideoCaptureDeviceFactory> factory_; 34 const std::unique_ptr<VideoCaptureDeviceFactory> factory_;
49 std::vector<VideoCaptureDeviceInfo> devices_info_cache_; 35 std::vector<VideoCaptureDeviceInfo> devices_info_cache_;
50 36
51 base::ThreadChecker thread_checker_; 37 base::ThreadChecker thread_checker_;
52 }; 38 };
53 39
54 } // namespace media 40 } // namespace media
55 41
56 #endif // MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_DEVICE_FACTORY_H_ 42 #endif // MEDIA_CAPTURE_VIDEO_VIDEO_CAPTURE_SYSTEM_IMPL_H_
OLDNEW
« no previous file with comments | « media/capture/video/video_capture_system.cc ('k') | media/capture/video/video_capture_system_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698