Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder.cc

Issue 2787693002: Remove more dead app list code. (Closed)
Patch Set: updated comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/extension_app_model_builder.cc
diff --git a/chrome/browser/ui/app_list/extension_app_model_builder.cc b/chrome/browser/ui/app_list/extension_app_model_builder.cc
index c01124ba1bcbaefdd0951dbfb22752f9b755581d..5a0f76b7114fd33b672132855391d30750a1fa62 100644
--- a/chrome/browser/ui/app_list/extension_app_model_builder.cc
+++ b/chrome/browser/ui/app_list/extension_app_model_builder.cc
@@ -11,7 +11,6 @@
#include "base/callback.h"
#include "base/memory/ptr_util.h"
#include "chrome/browser/extensions/extension_ui_util.h"
-#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/install_tracker.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
@@ -22,7 +21,6 @@
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
-#include "extensions/browser/extensions_browser_client.h"
#include "extensions/browser/pref_names.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
@@ -47,20 +45,6 @@ void ExtensionAppModelBuilder::InitializePrefChangeRegistrars() {
prefs::kHideWebStoreIcon,
base::Bind(&ExtensionAppModelBuilder::OnProfilePreferenceChanged,
base::Unretained(this)));
-
- if (!extensions::util::IsNewBookmarkAppsEnabled())
- return;
-
- // TODO(calamity): analyze the performance impact of doing this every
- // extension pref change.
- extensions::ExtensionsBrowserClient* client =
- extensions::ExtensionsBrowserClient::Get();
- extension_pref_change_registrar_.Init(
- client->GetPrefServiceForContext(profile()));
- extension_pref_change_registrar_.Add(
- extensions::pref_names::kExtensions,
- base::Bind(&ExtensionAppModelBuilder::OnExtensionPreferenceChanged,
- base::Unretained(this)));
}
void ExtensionAppModelBuilder::OnProfilePreferenceChanged() {
@@ -87,10 +71,6 @@ void ExtensionAppModelBuilder::OnProfilePreferenceChanged() {
}
}
-void ExtensionAppModelBuilder::OnExtensionPreferenceChanged() {
- model()->NotifyExtensionPreferenceChanged();
-}
-
void ExtensionAppModelBuilder::OnBeginExtensionInstall(
const ExtensionInstallParams& params) {
if (!params.is_app)
« no previous file with comments | « chrome/browser/ui/app_list/extension_app_model_builder.h ('k') | chrome/browser/ui/app_list/search/app_search_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698