Remove more dead app list code.

chrome/browser/ui/app_list/extension_app_model_builder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/extension_app_model_builder.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/extensions/extension_ui_util.h"
-#include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/install_tracker.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
 #include "chrome/browser/ui/app_list/app_list_syncable_service.h"
 #include "chrome/browser/ui/app_list/extension_app_item.h"
 #include "chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h"
 #include "chrome/common/pref_names.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
-#include "extensions/browser/extensions_browser_client.h"
 #include "extensions/browser/pref_names.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_set.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_operations.h"
 
 using extensions::Extension;
 
 ExtensionAppModelBuilder::ExtensionAppModelBuilder(
     AppListControllerDelegate* controller)
     : AppListModelBuilder(controller, ExtensionAppItem::kItemType) {
 }
 
 ExtensionAppModelBuilder::~ExtensionAppModelBuilder() {
   OnShutdown();
 }
 
 void ExtensionAppModelBuilder::InitializePrefChangeRegistrars() {
   profile_pref_change_registrar_.Init(profile()->GetPrefs());
   profile_pref_change_registrar_.Add(
       prefs::kHideWebStoreIcon,
       base::Bind(&ExtensionAppModelBuilder::OnProfilePreferenceChanged,
                  base::Unretained(this)));
-
-  if (!extensions::util::IsNewBookmarkAppsEnabled())
-    return;
-
-  // TODO(calamity): analyze the performance impact of doing this every
-  // extension pref change.
-  extensions::ExtensionsBrowserClient* client =
-      extensions::ExtensionsBrowserClient::Get();
-  extension_pref_change_registrar_.Init(
-      client->GetPrefServiceForContext(profile()));
-  extension_pref_change_registrar_.Add(
-    extensions::pref_names::kExtensions,
-    base::Bind(&ExtensionAppModelBuilder::OnExtensionPreferenceChanged,
-               base::Unretained(this)));
 }
 
 void ExtensionAppModelBuilder::OnProfilePreferenceChanged() {
   extensions::ExtensionSet extensions;
   controller()->GetApps(profile(), &extensions);
 
   for (extensions::ExtensionSet::const_iterator app = extensions.begin();
        app != extensions.end(); ++app) {
     bool should_display =
         extensions::ui_util::ShouldDisplayInAppLauncher(app->get(), profile());
     bool does_display = GetExtensionAppItem((*app)->id()) != nullptr;
 
     if (should_display == does_display)
       continue;
 
     if (should_display) {
       InsertApp(CreateAppItem((*app)->id(),
                               "",
                               gfx::ImageSkia(),
                               (*app)->is_platform_app()));
     } else {
       RemoveApp((*app)->id(), false);
     }
   }
 }
 
-void ExtensionAppModelBuilder::OnExtensionPreferenceChanged() {
-  model()->NotifyExtensionPreferenceChanged();
-}
-
 void ExtensionAppModelBuilder::OnBeginExtensionInstall(
     const ExtensionInstallParams& params) {
   if (!params.is_app)
     return;
 
   DVLOG(2) << service() << ": OnBeginExtensionInstall: "
            << params.extension_id.substr(0, 8);
   ExtensionAppItem* existing_item = GetExtensionAppItem(params.extension_id);
   if (existing_item) {
     existing_item->SetIsInstalling(true);
@@ skipping 134 matching lines @@
                             "",
                             gfx::ImageSkia(),
                             (*app)->is_platform_app()));
   }
 }
 
 ExtensionAppItem* ExtensionAppModelBuilder::GetExtensionAppItem(
     const std::string& extension_id) {
   return static_cast<ExtensionAppItem*>(GetAppItem(extension_id));
 }