Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2787683002: cleanup: Cleanup the TileImageInt APIs (Closed)

Created:
3 years, 8 months ago by Qiang(Joe) Xu
Modified:
3 years, 8 months ago
Reviewers:
danakj, Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cleanup: Cleanup the TileImageInt APIs BUG=706441 TEST=none Review-Url: https://codereview.chromium.org/2787683002 Cr-Commit-Position: refs/heads/master@{#461216} Committed: https://chromium.googlesource.com/chromium/src/+/45ad7627ca8532008afad85705e13facbb815ffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M chrome/browser/ui/views/frame/browser_header_painter_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas.h View 1 chunk +1 line, -10 lines 0 comments Download
M ui/gfx/canvas.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Qiang(Joe) Xu
PTAL, thanks!
3 years, 8 months ago (2017-03-30 00:24:56 UTC) #6
Peter Kasting
LGTM
3 years, 8 months ago (2017-03-30 00:27:06 UTC) #7
danakj
LGTM
3 years, 8 months ago (2017-03-31 14:52:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787683002/1
3 years, 8 months ago (2017-03-31 16:10:45 UTC) #12
commit-bot: I haz the power
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry ...
3 years, 8 months ago (2017-03-31 18:50:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787683002/1
3 years, 8 months ago (2017-03-31 20:40:14 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 20:47:40 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45ad7627ca8532008afad85705e1...

Powered by Google App Engine
This is Rietveld 408576698