Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2787633002: Disable PrintPreviewDestinationSearchTest.Select (Closed)

Created:
3 years, 8 months ago by stgao
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang, wjmaclean, skau
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable PrintPreviewDestinationSearchTest.Select BUG=702640 Review-Url: https://codereview.chromium.org/2787633002 Cr-Commit-Position: refs/heads/master@{#460627} Committed: https://chromium.googlesource.com/chromium/src/+/d2672f44f61002cfff2d7fd5a4bc70d54d903304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/webui/print_preview_destination_search_test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
stgao
mind a sanity check? I haven't disabled a js-based test before, so not sure if ...
3 years, 8 months ago (2017-03-29 20:40:53 UTC) #2
wjmaclean
On 2017/03/29 20:40:53, stgao(ping after 24h) wrote: > mind a sanity check? > > I ...
3 years, 8 months ago (2017-03-29 20:43:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787633002/1
3 years, 8 months ago (2017-03-29 20:44:45 UTC) #5
Lei Zhang
lgtm
3 years, 8 months ago (2017-03-29 20:48:59 UTC) #7
skau
lgtm
3 years, 8 months ago (2017-03-29 21:55:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/182738)
3 years, 8 months ago (2017-03-30 01:45:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787633002/1
3 years, 8 months ago (2017-03-30 02:01:53 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 02:20:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2672f44f61002cfff2d7fd5a4bc...

Powered by Google App Engine
This is Rietveld 408576698