Add NetworkStateTest helper class

Add NetworkStateTest helper class

This adds a testing::Test wrapper to simplify adding tests that rely
on NetworkStateHandler.

It converts AutoConnecthandlerTest and NetworkConnectionHandlerTest
to use the helper.

BUG=none

Review-Url: https://codereview.chromium.org/2787613002
Cr-Commit-Position: refs/heads/master@{#460550}
Committed: https://chromium.googlesource.com/chromium/src/+/888a70ed4f6e77b4019e24978a34cfbd2698acad

[stevenjb, 2017-03-29 19:28:30]

stevenjb@chromium.org changed reviewers:
+ khorimoto@chromium.org

[Kyle Horimoto, 2017-03-29 20:18:32]

https://codereview.chromium.org/2787613002/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_test.h (right):

https://codereview.chromium.org/2787613002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_test.h:36: std::string
GetServiceStringProperty(const std::string& service_path,
Should this class also have a mechanism for setting properties?

[stevenjb, 2017-03-29 20:29:16]

https://codereview.chromium.org/2787613002/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_test.h (right):

https://codereview.chromium.org/2787613002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_test.h:36: std::string
GetServiceStringProperty(const std::string& service_path,
On 2017/03/29 20:18:32, Kyle Horimoto wrote:
> Should this class also have a mechanism for setting properties?

If/when we need it we can and should add it. The current tests just use
ConfigureService then call into their handler code and query the state.

[Kyle Horimoto, 2017-03-29 20:30:30]

lgtm

[stevenjb, 2017-03-29 20:33:27]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-03-29 20:34:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:17:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490819607651250,
"parent_rev": "2f952e4c39887d65126ca4cd67a897fc6d409fb9", "commit_rev":
"888a70ed4f6e77b4019e24978a34cfbd2698acad"}

[commit-bot: I haz the power, 2017-03-29 22:18:11]

Description was changed from

==========
Add NetworkStateTest helper class

This adds a testing::Test wrapper to simplify adding tests that rely
on NetworkStateHandler.

It converts AutoConnecthandlerTest and NetworkConnectionHandlerTest
to use the helper.

BUG=none
==========

to

==========
Add NetworkStateTest helper class

This adds a testing::Test wrapper to simplify adding tests that rely
on NetworkStateHandler.

It converts AutoConnecthandlerTest and NetworkConnectionHandlerTest
to use the helper.

BUG=none

Review-Url: https://codereview.chromium.org/2787613002
Cr-Commit-Position: refs/heads/master@{#460550}
Committed:
https://chromium.googlesource.com/chromium/src/+/888a70ed4f6e77b4019e24978a34...
==========

[commit-bot: I haz the power, 2017-03-29 22:18:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/888a70ed4f6e77b4019e24978a34...