Remove DumpWithoutCrashing from ShouldAllowOpenURL.

chrome/browser/PRESUBMIT.py

Index: chrome/browser/PRESUBMIT.py
diff --git a/chrome/browser/PRESUBMIT.py b/chrome/browser/PRESUBMIT.py
index 0350a0624b30978bfd71b8b700d672338bc64f98..c7d26045d4c3dbf56923b9c73c76ced8ae18e91a 100644
--- a/chrome/browser/PRESUBMIT.py
+++ b/chrome/browser/PRESUBMIT.py
@@ -12,7 +12,6 @@ http://www.chromium.org/developers/web-development-style-guide for the rules
 checked for here.
 """
 
-
 def CheckChangeOnUpload(input_api, output_api):
   return _CommonChecks(input_api, output_api)
 
@@ -29,9 +28,17 @@ def _RunHistogramChecks(input_api, output_api, histogram_name):
         input_api.change.RepositoryRoot(),
         'tools', 'metrics', 'histograms')]
 
+    results = []
+
     import presubmit_bad_message_reasons
-    return presubmit_bad_message_reasons.PrecheckBadMessage(input_api,
-      output_api, histogram_name)
+    results.extend(presubmit_bad_message_reasons.PrecheckBadMessage(input_api,
+        output_api, histogram_name))
+
+    import presubmit_should_allow_open_url_histograms

[Dan Beam, 2017/04/04 22:03:46]

this identifier is ... long

can we make it shorter?

[alexmos, 2017/04/05 17:24:51]

Renamed to presubmit_scheme_histograms.py

+    results.extend(presubmit_should_allow_open_url_histograms.
+                   PrecheckShouldAllowOpenURLEnums(input_api, output_api))

[Dan Beam, 2017/04/04 22:03:46]

this_text_is_kind_of_repetitive.
ThisTextIsKindOfRepetitive()

[alexmos, 2017/04/05 17:24:51]

With the rename, this is hopefully not repetitive anymore.  I could make the
presubmit function more generic and remove ShouldAllowOpenURL from this
altogether.  I was thinking this can wait until we have a second use case for
the scheme enum (as Nick pointed out), at which point the enum will probably
move out to a more public place anyway.

+
+    return results
   except:
     return [output_api.PresubmitError('Could not verify histogram!')]
   finally: