Remove DumpWithoutCrashing from ShouldAllowOpenURL.

chrome/browser/PRESUBMIT.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for Chromium browser code.
 
 This script currently checks HTML/CSS/JS files in resources/ and ui/webui/.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools, and see
 http://www.chromium.org/developers/web-development-style-guide for the rules
 checked for here.
 """
 
-
 def CheckChangeOnUpload(input_api, output_api):
   return _CommonChecks(input_api, output_api)
 
 
 def CheckChangeOnCommit(input_api, output_api):
   return _CommonChecks(input_api, output_api)
 
 def _RunHistogramChecks(input_api, output_api, histogram_name):
   try:
     # Setup sys.path so that we can call histrogram code
     import sys
     original_sys_path = sys.path
     sys.path = sys.path + [input_api.os_path.join(
         input_api.change.RepositoryRoot(),
         'tools', 'metrics', 'histograms')]
 
+    results = []
+
     import presubmit_bad_message_reasons
-    return presubmit_bad_message_reasons.PrecheckBadMessage(input_api,
-      output_api, histogram_name)
+    results.extend(presubmit_bad_message_reasons.PrecheckBadMessage(input_api,
+        output_api, histogram_name))
+
+    import presubmit_should_allow_open_url_histograms

[Dan Beam, 2017/04/04 22:03:46]

this identifier is ... long

can we make it shorter?

[alexmos, 2017/04/05 17:24:51]

Renamed to presubmit_scheme_histograms.py

+    results.extend(presubmit_should_allow_open_url_histograms.
+                   PrecheckShouldAllowOpenURLEnums(input_api, output_api))

[Dan Beam, 2017/04/04 22:03:46]

this_text_is_kind_of_repetitive.
ThisTextIsKindOfRepetitive()

[alexmos, 2017/04/05 17:24:51]

With the rename, this is hopefully not repetitive anymore.  I could make the
presubmit function more generic and remove ShouldAllowOpenURL from this
altogether.  I was thinking this can wait until we have a second use case for
the scheme enum (as Nick pointed out), at which point the enum will probably
move out to a more public place anyway.

+
+    return results
   except:
     return [output_api.PresubmitError('Could not verify histogram!')]
   finally:
     sys.path = original_sys_path
 
 
 def _CommonChecks(input_api, output_api):
   """Checks common to both upload and commit."""
   results = []
 
@@ skipping 46 matching lines @@
     results.extend(html_checker.HtmlChecker(
         input_api, output_api, file_filter=is_resource).RunChecks())
     results.extend(js_checker.JSChecker(
         input_api, output_api, file_filter=is_resource).RunChecks())
     results.extend(_RunHistogramChecks(input_api, output_api,
       "BadMessageReasonChrome"))
   finally:
     sys.path = old_path
 
   return results