Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2787573002: InspectorOverlay: Don't copy from SharedBuffer to SharedBuffer. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

InspectorOverlay: Don't copy from SharedBuffer to SharedBuffer. WebData is already a RefPtr<SharedBuffer>. We don't need to copy the data. Review-Url: https://codereview.chromium.org/2787573002 Cr-Commit-Position: refs/heads/master@{#460486} Committed: https://chromium.googlesource.com/chromium/src/+/eb232647e62ce3b932af9d22fbe7572401ad3589

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jbroman
Trivial; noticed this while passing by.
3 years, 8 months ago (2017-03-29 18:52:56 UTC) #8
pfeldman
lgtm
3 years, 8 months ago (2017-03-29 19:06:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787573002/20001
3 years, 8 months ago (2017-03-29 19:08:22 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:25:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eb232647e62ce3b932af9d22fbe7...

Powered by Google App Engine
This is Rietveld 408576698