Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2787563002: [sb] Transfer histogram ownership to Varun. (Closed)

Created:
3 years, 8 months ago by Scott Hess - ex-Googler
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vakh (use Gerrit instead)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[sb] Transfer histogram ownership to Varun. Varun owns rolling out a new storage layer for safe browsing, which is currently taking over in stable. So these should all be removed soonish. BUG=705809, 701209 Review-Url: https://codereview.chromium.org/2787563002 Cr-Commit-Position: refs/heads/master@{#460647} Committed: https://chromium.googlesource.com/chromium/src/+/528e9669fe7420bc8299c323298c1cae6fc1d166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M tools/metrics/histograms/histograms.xml View 33 chunks +45 lines, -45 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Scott Hess - ex-Googler
This seems appropriate to me. The fact that I'm sneaking it in while Varun is ...
3 years, 8 months ago (2017-03-29 16:57:19 UTC) #2
Nathan Parker
lgtm I think that's fair. The purpose of ownership here is for a POC, and ...
3 years, 8 months ago (2017-03-29 17:08:07 UTC) #3
vakh (use Gerrit instead)
lgtm
3 years, 8 months ago (2017-03-29 17:09:14 UTC) #5
Scott Hess - ex-Googler
rkaplow@chromium.org for histogram OWNERS.
3 years, 8 months ago (2017-03-29 18:14:29 UTC) #7
rkaplow
lgtm
3 years, 8 months ago (2017-03-30 01:28:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787563002/1
3 years, 8 months ago (2017-03-30 01:32:46 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:44:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/528e9669fe7420bc8299c323298c...

Powered by Google App Engine
This is Rietveld 408576698