Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2787513002: Adding documentation for autoplay (Closed)

Created:
3 years, 8 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding documentation for autoplay BUG=None Review-Url: https://codereview.chromium.org/2787513002 Cr-Commit-Position: refs/heads/master@{#460722} Committed: https://chromium.googlesource.com/chromium/src/+/4b8096b24c1b0a1c77085b4d14f2f7bff9235d42

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -97 lines) Patch
D docs/audio_focus.md View 1 chunk +0 lines, -98 lines 0 comments Download
A + docs/media/audio_focus.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A docs/media/autoplay.md View 1 1 chunk +49 lines, -0 lines 0 comments Download
A docs/media/autoplay_by_attribute.png View Binary file 0 comments Download
A docs/media/autoplay_by_play_method.png View 1 Binary file 0 comments Download

Messages

Total messages: 11 (5 generated)
Zhiqiang Zhang (Slow)
3 years, 8 months ago (2017-03-29 15:42:37 UTC) #2
sandersd (OOO until July 31)
In autoplay_by_play_method.png, can 'Any state' say 'Paused' instead? lgtm. https://codereview.chromium.org/2787513002/diff/1/docs/media/autoplay.md File docs/media/autoplay.md (right): https://codereview.chromium.org/2787513002/diff/1/docs/media/autoplay.md#newcode48 docs/media/autoplay.md:48: ...
3 years, 8 months ago (2017-03-29 19:47:05 UTC) #3
Zhiqiang Zhang (Slow)
https://codereview.chromium.org/2787513002/diff/1/docs/media/autoplay.md File docs/media/autoplay.md (right): https://codereview.chromium.org/2787513002/diff/1/docs/media/autoplay.md#newcode48 docs/media/autoplay.md:48: video as normal `play()`. However if the page tries ...
3 years, 8 months ago (2017-03-30 11:15:48 UTC) #4
Zhiqiang Zhang (Slow)
On 2017/03/29 at 19:47:05, sandersd wrote: > In autoplay_by_play_method.png, can 'Any state' say 'Paused' instead? ...
3 years, 8 months ago (2017-03-30 11:17:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787513002/20001
3 years, 8 months ago (2017-03-30 11:17:40 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 11:29:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b8096b24c1b0a1c77085b4d14f2...

Powered by Google App Engine
This is Rietveld 408576698