Move FaviconAttributes to UI

ios/chrome/browser/ui/favicon/favicon_attributes_provider.h

Index: ios/chrome/browser/ui/favicon/favicon_attributes_provider.h
diff --git a/ios/chrome/browser/favicon/favicon_attributes_provider.h b/ios/chrome/browser/ui/favicon/favicon_attributes_provider.h
similarity index 85%
rename from ios/chrome/browser/favicon/favicon_attributes_provider.h
rename to ios/chrome/browser/ui/favicon/favicon_attributes_provider.h
index 49fc52371a9d9b9850f47f099a104dc3717f19e9..d9dd244ebe028e4dfffaa4150a509ef59e156ce6 100644
--- a/ios/chrome/browser/favicon/favicon_attributes_provider.h
+++ b/ios/chrome/browser/ui/favicon/favicon_attributes_provider.h
@@ -2,11 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef IOS_CHROME_BROWSER_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
-#define IOS_CHROME_BROWSER_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
+#ifndef IOS_CHROME_BROWSER_UI_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
+#define IOS_CHROME_BROWSER_UI_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
 
 #import <UIKit/UIKit.h>
-#import "ios/chrome/browser/favicon/favicon_attributes.h"
+#import "ios/chrome/browser/ui/favicon/favicon_attributes.h"

[sdefresne, 2017/03/31 08:35:03]

This is the problematic dependency. ios/chrome/browser should not depends on
ios/chrome/browser/ui.

One way to solve this is to create a model only FaviconAttributes like structure
and convert it to ui FaviconAttributes in the ui layer. We did this multiple
time during componentization.

[gambard, 2017/03/31 08:37:02]

I don't understand. This file is in ios/chrome/browser/ui...

[sdefresne, 2017/04/03 09:31:53]

Sorry, I didn't see that all files where moved.

 
 namespace favicon {
 class LargeIconService;
@@ -41,4 +41,4 @@ class GURL;
 
 @end
 
-#endif  // IOS_CHROME_BROWSER_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
+#endif  // IOS_CHROME_BROWSER_UI_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_