Move FaviconAttributes to UI

ios/chrome/browser/ui/favicon/favicon_attributes_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef IOS_CHROME_BROWSER_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
-#define IOS_CHROME_BROWSER_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
+#ifndef IOS_CHROME_BROWSER_UI_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
+#define IOS_CHROME_BROWSER_UI_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
 
 #import <UIKit/UIKit.h>
-#import "ios/chrome/browser/favicon/favicon_attributes.h"
+#import "ios/chrome/browser/ui/favicon/favicon_attributes.h"

[sdefresne, 2017/03/31 08:35:03]

This is the problematic dependency. ios/chrome/browser should not depends on
ios/chrome/browser/ui.

One way to solve this is to create a model only FaviconAttributes like structure
and convert it to ui FaviconAttributes in the ui layer. We did this multiple
time during componentization.

[gambard, 2017/03/31 08:37:02]

I don't understand. This file is in ios/chrome/browser/ui...

[sdefresne, 2017/04/03 09:31:53]

Sorry, I didn't see that all files where moved.

 
 namespace favicon {
 class LargeIconService;
 }  // namespace favicon
 
 @class FaviconViewProvider;
 class GURL;
 
 // Object to fetch favicon attributes by URL - an image or a fallback icon if
 // there is no favicon image available with large enough resolution.
@@ skipping 14 matching lines @@
 
 // LargeIconService used to fetch favicons.
 @property(nonatomic, readonly) favicon::LargeIconService* largeIconService;
 // Minimal acceptable favicon size. Below that, will fall back to a monogram.
 @property(nonatomic, readonly) CGFloat minSize;
 // Expected favicon size (in points). Will downscale favicon to this.
 @property(nonatomic, readonly) CGFloat faviconSize;
 
 @end
 
-#endif  // IOS_CHROME_BROWSER_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_
+#endif  // IOS_CHROME_BROWSER_UI_FAVICON_FAVICON_ATTRIBUTES_PROVIDER_H_