Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 2787453003: Revert of Use TaskScheduler instead of blocking pool in content_hash_fetcher.cc. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of blocking pool in content_hash_fetcher.cc. (patchset #4 id:60001 of https://codereview.chromium.org/2672623006/ ) Reason for revert: Causing flakyness https://crbug.com/702300 Original issue's description: > Use TaskScheduler instead of blocking pool in content_hash_fetcher.cc. > > The blocking pool is being deprecated in favor of TaskScheduler. > > BUG=667892 > R=finnur@chromium.org > > Review-Url: https://codereview.chromium.org/2672623006 > Cr-Commit-Position: refs/heads/master@{#451473} > Committed: https://chromium.googlesource.com/chromium/src/+/8a07a9568d954e17452e678852692838a613f3c1 TBR=rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=667892 Review-Url: https://codereview.chromium.org/2787453003 Cr-Commit-Position: refs/heads/master@{#460381} Committed: https://chromium.googlesource.com/chromium/src/+/3056319cc7510415c98bb98e2529dfbcb1d973c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M extensions/browser/content_hash_fetcher.cc View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
fdoray
Created Revert of Use TaskScheduler instead of blocking pool in content_hash_fetcher.cc.
3 years, 8 months ago (2017-03-29 13:46:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787453003/1
3 years, 8 months ago (2017-03-29 13:46:43 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 14:34:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3056319cc7510415c98bb98e2529...

Powered by Google App Engine
This is Rietveld 408576698