On heap tracking datastructure overflow, degrade instead of CHECK()

On heap tracking datastructure overflow, degrade instead of CHECK()

Based on ajwong's CL https://codereview.chromium.org/2784783003/
This allows the heap profiler to on systems with heavy memory usage
(sometimes caused by strange profiles).

Next step is to surface the overflow on the tracing UI.

BUG=698079
Review-Url: https://codereview.chromium.org/2787383002
Cr-Commit-Position: refs/heads/master@{#461485}
Committed: https://chromium.googlesource.com/chromium/src/+/c1d887e1b41c37348a412bcb956b641ef5b5caf1

[Primiano Tucci (use gerrit), 2017-03-31 18:24:05]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 18:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2017-03-31 18:28:04]

Description was changed from

==========
On heap tracking datastructure overflow, degrade instead of CHECK()

This allows the heap profiler to on systems with heavy memory usage
(sometimes caused by strange profiles).

Next step is to surface the overflow on the tracing UI.

BUG=698079

patch from issue 2784783003 at patchset 40001
(http://crrev.com/2784783003#ps40001)
==========

to

==========
On heap tracking datastructure overflow, degrade instead of CHECK()

This allows the heap profiler to on systems with heavy memory usage
(sometimes caused by strange profiles).

Next step is to surface the overflow on the tracing UI.

BUG=698079

patch from issue 2784783003 at patchset 40001
(http://crrev.com/2784783003#ps40001)
==========

[Primiano Tucci (use gerrit), 2017-03-31 19:05:35]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 19:06:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2017-03-31 19:06:29]

Description was changed from

==========
On heap tracking datastructure overflow, degrade instead of CHECK()

This allows the heap profiler to on systems with heavy memory usage
(sometimes caused by strange profiles).

Next step is to surface the overflow on the tracing UI.

BUG=698079

patch from issue 2784783003 at patchset 40001
(http://crrev.com/2784783003#ps40001)
==========

to

==========
On heap tracking datastructure overflow, degrade instead of CHECK()

Based on ajwong's CL https://codereview.chromium.org/2784783003/
This allows the heap profiler to on systems with heavy memory usage
(sometimes caused by strange profiles).

Next step is to surface the overflow on the tracing UI.

BUG=698079
==========

[Primiano Tucci (use gerrit), 2017-03-31 19:06:30]

primiano@chromium.org changed reviewers:
+ ajwong@chromium.org, dskiba@chromium.org

[commit-bot: I haz the power, 2017-03-31 20:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 20:07:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Primiano Tucci (use gerrit), 2017-03-31 20:17:24]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 20:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 21:32:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 21:32:01]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2017-04-03 08:24:09]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 08:24:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 09:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 09:57:55]

Dry run: This issue passed the CQ dry run.

[awong, 2017-04-03 18:27:21]

The CQ bit was checked by ajwong@chromium.org

[awong, 2017-04-03 18:27:31]

On 2017/03/31 19:07:33, Primiano Tucci wrote:

LGTM

[awong, 2017-04-03 18:27:55]

On 2017/04/03 18:27:31, awong wrote:
> On 2017/03/31 19:07:33, Primiano Tucci wrote:
> 
> LGTM

Talked through the code on chat. Made sense. Will add another CL that adds more
comments.

[awong, 2017-04-03 18:27:58]

On 2017/04/03 18:27:31, awong wrote:
> On 2017/03/31 19:07:33, Primiano Tucci wrote:
> 
> LGTM

Talked through the code on chat. Made sense. Will add another CL that adds more
comments.

[commit-bot: I haz the power, 2017-04-03 18:28:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 18:40:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491244041977300,
"parent_rev": "df0952b6d946aeddee245b2085acba1a0e7ba654", "commit_rev":
"c1d887e1b41c37348a412bcb956b641ef5b5caf1"}

[commit-bot: I haz the power, 2017-04-03 18:41:11]

Description was changed from

==========
On heap tracking datastructure overflow, degrade instead of CHECK()

Based on ajwong's CL https://codereview.chromium.org/2784783003/
This allows the heap profiler to on systems with heavy memory usage
(sometimes caused by strange profiles).

Next step is to surface the overflow on the tracing UI.

BUG=698079
==========

to

==========
On heap tracking datastructure overflow, degrade instead of CHECK()

Based on ajwong's CL https://codereview.chromium.org/2784783003/
This allows the heap profiler to on systems with heavy memory usage
(sometimes caused by strange profiles).

Next step is to surface the overflow on the tracing UI.

BUG=698079

Review-Url: https://codereview.chromium.org/2787383002
Cr-Commit-Position: refs/heads/master@{#461485}
Committed:
https://chromium.googlesource.com/chromium/src/+/c1d887e1b41c37348a412bcb956b...
==========

[commit-bot: I haz the power, 2017-04-03 18:41:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c1d887e1b41c37348a412bcb956b...