Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2787363003: gpu: Add a couple of unit-tests for GpuService. (Closed)

Created:
3 years, 8 months ago by sadrul
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add a couple of unit-tests for GpuService. Add a couple of unit-tests to verify that GpuService can be destroyed safely both after incoming GpuServiceRequest have been bound, or while they are scheduled to be bound. BUG=706375, 706357 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2787363003 Cr-Commit-Position: refs/heads/master@{#461658} Committed: https://chromium.googlesource.com/chromium/src/+/94d7bbdbc5110011a16039c47afa60c4ee065687

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -4 lines) Patch
M gpu/ipc/service/gpu_watchdog_thread.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/service/gpu_watchdog_thread.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/gpu/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
A services/ui/gpu/gpu_service_unittest.cc View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (24 generated)
sadrul
3 years, 8 months ago (2017-04-03 15:25:27 UTC) #15
piman
lgtm
3 years, 8 months ago (2017-04-03 23:55:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787363003/40001
3 years, 8 months ago (2017-04-04 02:06:14 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/397492)
3 years, 8 months ago (2017-04-04 02:38:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787363003/60001
3 years, 8 months ago (2017-04-04 08:06:35 UTC) #27
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 08:12:07 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/94d7bbdbc5110011a16039c47afa...

Powered by Google App Engine
This is Rietveld 408576698