Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2787343002: [regexp] Revert to ZoneList usage in @@replace (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Revert to ZoneList usage in @@replace Fixes a crash found by clusterfuzz caused by a call to std::vector::reserve with a huge capacity, and reverts to ZoneList handling as a tentative fix for performance regressions on the slow @@replace path. BUG=chromium:707187, chromium:706748, v8:5437 Review-Url: https://codereview.chromium.org/2787343002 Cr-Commit-Position: refs/heads/master@{#44311} Committed: https://chromium.googlesource.com/v8/v8/+/686c37839c00e1510625b6cb11a7f18a459eb2a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M src/runtime/runtime-regexp.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-707187.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jgruber
3 years, 8 months ago (2017-03-31 14:07:48 UTC) #4
Yang
On 2017/03/31 14:07:48, jgruber wrote: lgtm
3 years, 8 months ago (2017-03-31 14:10:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787343002/1
3 years, 8 months ago (2017-03-31 14:24:56 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 14:38:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/686c37839c00e1510625b6cb11a7f18a459...

Powered by Google App Engine
This is Rietveld 408576698