Add strict mode exception to addPreferencesFromResource calls

Add StrictMode exception for addPreferencesFromResource calls.

Add a helper method that disables StrictMode temporarily and loads preferences to ClearBrowsingDataPrefences, AboutChromePreferences and AutofillAndPaymentsPreferences to avoid StrictModeViolation errors.

BUG=707174, 692125, 692130
Review-Url: https://codereview.chromium.org/2787323002
Cr-Commit-Position: refs/heads/master@{#461462}
Committed: https://chromium.googlesource.com/chromium/src/+/92933ff654ebb9bb8be0de9eaad60668eb395443

[dullweber, 2017-03-31 09:03:28]

dullweber@chromium.org changed reviewers:
+ msramek@chromium.org, twellington@chromium.org

[dullweber, 2017-03-31 09:03:29]

The CBD tests caused a StrictModeException. I fixed it similar to this cl:
http://crrev.com/2680013010

[Theresa, 2017-03-31 15:18:43]

https://codereview.chromium.org/2787323002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
(right):

https://codereview.chromium.org/2787323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:506:
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
Please see crbug.com/692125 for a discussion on allowing disk reads for adding
preferences from resources.  This is actually an issues for all of our calls to
addPreferencesFromResources() and I would like to isolate this exception to one
helper method that the rest of our code relies on.

[dullweber, 2017-04-03 09:33:14]

https://codereview.chromium.org/2787323002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
(right):

https://codereview.chromium.org/2787323002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:506:
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
On 2017/03/31 15:18:42, Theresa wrote:
> Please see crbug.com/692125 for a discussion on allowing disk reads for adding
> preferences from resources.  This is actually an issues for all of our calls
to
> addPreferencesFromResources() and I would like to isolate this exception to
one
> helper method that the rest of our code relies on.

Thanks for the link. I added a helper method to load preferences safely.

[dullweber, 2017-04-03 09:43:08]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 09:43:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-04-03 09:43:20]

On 2017/04/03 09:33:14, dullweber wrote:
>
https://codereview.chromium.org/2787323002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
> (right):
> 
>
https://codereview.chromium.org/2787323002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java:506:
> StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
> On 2017/03/31 15:18:42, Theresa wrote:
> > Please see crbug.com/692125 for a discussion on allowing disk reads for
adding
> > preferences from resources.  This is actually an issues for all of our calls
> to
> > addPreferencesFromResources() and I would like to isolate this exception to
> one
> > helper method that the rest of our code relies on.
> 
> Thanks for the link. I added a helper method to load preferences safely.

I also added the helper method to the other classes that currently have bug
reports about this issue.

[dullweber, 2017-04-03 09:48:39]

Description was changed from

==========
Add strict mode exception to ClearBrowsingDataPrefences#onCreate

BUG=707174
==========

to

==========
Add StrictMode exception for addPreferencesFromResource to 
ClearBrowsingDataPrefences, AboutChromePreferences and
AutofillAndPaymentsPreferences to avoid StrictModeViolation.

BUG=707174,692125,692130
==========

[dullweber, 2017-04-03 09:52:19]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 09:52:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 11:18:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 11:18:04]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dullweber, 2017-04-03 14:23:59]

Description was changed from

==========
Add StrictMode exception for addPreferencesFromResource to 
ClearBrowsingDataPrefences, AboutChromePreferences and
AutofillAndPaymentsPreferences to avoid StrictModeViolation.

BUG=707174,692125,692130
==========

to

==========
Add StrictMode exception for addPreferencesFromResource calls.

Add a helper method that disables StrictMode temporarily and loads preferences
to ClearBrowsingDataPrefences, AboutChromePreferences and
AutofillAndPaymentsPreferences to avoid StrictModeViolation errors.

BUG=707174,692125,692130
==========

[Theresa, 2017-04-03 14:56:17]

lgtm

Thank you very much for making the helper method!

https://codereview.chromium.org/2787323002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesHelper.java
(right):

https://codereview.chromium.org/2787323002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesHelper.java:14:
public class PreferencesHelper {
nitL Let's call this PreferenceUtils

https://codereview.chromium.org/2787323002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesHelper.java:17:
* StrictModeViolation. See http://b/36803386.
nit: Link to the crbug rather than the b/ since b/ is internal

[dullweber, 2017-04-03 15:14:01]

https://codereview.chromium.org/2787323002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesHelper.java
(right):

https://codereview.chromium.org/2787323002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesHelper.java:14:
public class PreferencesHelper {
On 2017/04/03 14:56:17, Theresa wrote:
> nitL Let's call this PreferenceUtils

Done.

https://codereview.chromium.org/2787323002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesHelper.java:17:
* StrictModeViolation. See http://b/36803386.
On 2017/04/03 14:56:17, Theresa wrote:
> nit: Link to the crbug rather than the b/ since b/ is internal

Done.

[dullweber, 2017-04-03 15:14:36]

The CQ bit was checked by dullweber@chromium.org

[dullweber, 2017-04-03 15:14:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2787323002/#ps80001
(title: "rename helper to util")

[commit-bot: I haz the power, 2017-04-03 15:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:32:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491232476655180,
"parent_rev": "a39db84c07f26bd56b8a1884b2082a559c363402", "commit_rev":
"92933ff654ebb9bb8be0de9eaad60668eb395443"}

[commit-bot: I haz the power, 2017-04-03 17:33:20]

Description was changed from

==========
Add StrictMode exception for addPreferencesFromResource calls.

Add a helper method that disables StrictMode temporarily and loads preferences
to ClearBrowsingDataPrefences, AboutChromePreferences and
AutofillAndPaymentsPreferences to avoid StrictModeViolation errors.

BUG=707174,692125,692130
==========

to

==========
Add StrictMode exception for addPreferencesFromResource calls.

Add a helper method that disables StrictMode temporarily and loads preferences
to ClearBrowsingDataPrefences, AboutChromePreferences and
AutofillAndPaymentsPreferences to avoid StrictModeViolation errors.

BUG=707174,692125,692130

Review-Url: https://codereview.chromium.org/2787323002
Cr-Commit-Position: refs/heads/master@{#461462}
Committed:
https://chromium.googlesource.com/chromium/src/+/92933ff654ebb9bb8be0de9eaad6...
==========

[commit-bot: I haz the power, 2017-04-03 17:33:21]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/92933ff654ebb9bb8be0de9eaad6...