Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2787303002: [NTP::Downloads] Use last access time to filter old asset downloads. (Closed)

Created:
3 years, 8 months ago by vitaliii
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::Downloads] Use last access time to filter old asset downloads. Previously, last_access_time was not provided in DownloadItem. Now it is, so in this CL we use it to filter out outdaded asset downloads (same way as it was done for offline pages - either creation time or last access time (if ever opened) is considered). BUG=689965 Review-Url: https://codereview.chromium.org/2787303002 Cr-Commit-Position: refs/heads/master@{#461671} Committed: https://chromium.googlesource.com/chromium/src/+/cdc707f2ed4d9fa302d5c81259ac67618d6c2b56

Patch Set 1 #

Patch Set 2 : rebase. #

Patch Set 3 : clean rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M chrome/browser/ntp_snippets/download_suggestions_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download
M content/public/test/fake_download_item.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M content/public/test/fake_download_item.cc View 1 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
vitaliii
Hi phajdan.jr@ and jkrcal@, phajdan.jr, could you have a look at public/test? jkrcal, could you ...
3 years, 8 months ago (2017-03-31 11:28:28 UTC) #8
jkrcal
lgtm
3 years, 8 months ago (2017-03-31 11:49:56 UTC) #9
Paweł Hajdan Jr.
LGTM
3 years, 8 months ago (2017-04-03 20:03:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787303002/40001
3 years, 8 months ago (2017-04-04 08:04:55 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 09:59:01 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cdc707f2ed4d9fa302d5c81259ac...

Powered by Google App Engine
This is Rietveld 408576698