Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2787263005: Revert of fix size check for drawBitmap fast-path in SkBitmapDevice::drawBitmapRect (Closed)

Created:
3 years, 8 months ago by mtklein_C
Modified:
3 years, 8 months ago
Reviewers:
lsalzman1, caryclark, reed1
CC:
reviews_skia.org, hcm
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of fix size check for drawBitmap fast-path in SkBitmapDevice::drawBitmapRect (patchset #2 id:20001 of https://codereview.chromium.org/2089583002/ ) Reason for revert: I agree the diffs are not meaningful, but nevertheless their existence is blocking the roll into Chrome. (https://storage.googleapis.com/chromium-layout-test-archives/linux_trusty_blink_rel/7376/layout-test-results/results.html) Original issue's description: > Fix the size check for the drawBitmap fast-path in SkBitmapDevice::drawBitmapRect. It would fail when the source rectangle had a non-zero offset, in which case it would compare the source rectangle with the offset to the extracted bitmap size, which always fails. The only thing that should matter is that the source rectangle and extract bitmap have the same size, since the offset gets added onto the matrix. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2089583002 > > Review-Url: https://codereview.chromium.org/2089583002 > Committed: https://skia.googlesource.com/skia/+/ea9bc0c07b5dae78a9a449d7d7a07fc79262d41a TBR=reed@google.com,caryclark@google.com,lsalzman@mozilla.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2787263005 Committed: https://skia.googlesource.com/skia/+/65c74f1368290551c60e4cd46e08ea1d6970b3d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/core/SkBitmapDevice.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mtklein_C
Created Revert of fix size check for drawBitmap fast-path in SkBitmapDevice::drawBitmapRect
3 years, 8 months ago (2017-04-01 01:36:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787263005/1
3 years, 8 months ago (2017-04-01 01:36:36 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 01:36:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/65c74f1368290551c60e4cd46e08ea1d6970b3d3

Powered by Google App Engine
This is Rietveld 408576698