Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2787163002: Increase the range of WasmFunctionsPerModule histogram. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
Reviewers:
bbudge, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Increase the range of WasmFunctionsPerModule histogram. Looking at UMA results, we are getting a fair number of modules with more than 10,000 functions (5.2%) that are being lumped into the maximal entry. To get more visibility into what values are being lumped, this CL lifts the maximum to 100,000. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2787163002 Cr-Commit-Position: refs/heads/master@{#44314} Committed: https://chromium.googlesource.com/v8/v8/+/8ed72f91a01a72b9adb8125b53f19cbaa50c694c

Patch Set 1 #

Patch Set 2 : Update for both asm and wasm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M src/counters.h View 1 1 chunk +19 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kschimpf
Please review. Thanks.
3 years, 8 months ago (2017-03-30 21:57:04 UTC) #5
bbudge
lgtm
3 years, 8 months ago (2017-03-30 22:41:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787163002/20001
3 years, 8 months ago (2017-03-31 15:23:18 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 15:24:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8ed72f91a01a72b9adb8125b53f19cbaa50...

Powered by Google App Engine
This is Rietveld 408576698