Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2787123006:
Remove Base Class from ScopedComPtr and Deprecate (Closed)
DescriptionRemove Base Class from ScopedComPtr and Deprecate
Removed scoped_refptr as a superclass of ScopedComPtr and inlined
necessary methods scoped_refptr from to keep the build compiling.
This also starts the train of CLs that deprecates ScopedComPtr in favor of
ComPtr.
BUG=638327
Review-Url: https://codereview.chromium.org/2787123006
Cr-Commit-Position: refs/heads/master@{#461531}
Committed: https://chromium.googlesource.com/chromium/src/+/c2bea96144eaa81bf54ac4a341a9110a015fe918
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add swap() (is_chrome_branded isn't run on the CQ) #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove Base Class from ScopedComPtr Removed scoped_refptr as a superclass of ScopedComPtr and inlined necessary methods scoped_refptr from to keep the build compiling. BUG=638327 ========== to ========== Remove Base Class from ScopedComPtr and Deprecate Removed scoped_refptr as a superclass of ScopedComPtr and inlined necessary methods scoped_refptr from to keep the build compiling. BUG=638327 ==========
Description was changed from ========== Remove Base Class from ScopedComPtr and Deprecate Removed scoped_refptr as a superclass of ScopedComPtr and inlined necessary methods scoped_refptr from to keep the build compiling. BUG=638327 ========== to ========== Remove Base Class from ScopedComPtr and Deprecate Removed scoped_refptr as a superclass of ScopedComPtr and inlined necessary methods scoped_refptr from to keep the build compiling. This also starts the train of CLs that deprecates ScopedComPtr in favor of ComPtr. BUG=638327 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
robliao@chromium.org changed reviewers: + scottmg@chromium.org
Here we go!
lgtm https://codereview.chromium.org/2787123006/diff/1/base/win/scoped_comptr.h File base/win/scoped_comptr.h (right): https://codereview.chromium.org/2787123006/diff/1/base/win/scoped_comptr.h#ne... base/win/scoped_comptr.h:62: ptr_ = nullptr; I assume you swapped these on purpose?
Also added swap(). The CQ doesn't run branded builds! https://codereview.chromium.org/2787123006/diff/1/base/win/scoped_comptr.h File base/win/scoped_comptr.h (right): https://codereview.chromium.org/2787123006/diff/1/base/win/scoped_comptr.h#ne... base/win/scoped_comptr.h:62: ptr_ = nullptr; On 2017/04/03 18:23:22, scottmg wrote: > I assume you swapped these on purpose? Yep. I figured I would go ahead and align with ComPtr here while I was stripping the this->'s.
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2787123006/#ps20001 (title: "Add swap() (is_chrome_branded isn't run on the CQ)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491252412629510,
"parent_rev": "9ddb2190fe84221506e9ada748bbea36f45b050d", "commit_rev":
"c2bea96144eaa81bf54ac4a341a9110a015fe918"}
Message was sent while issue was closed.
Description was changed from ========== Remove Base Class from ScopedComPtr and Deprecate Removed scoped_refptr as a superclass of ScopedComPtr and inlined necessary methods scoped_refptr from to keep the build compiling. This also starts the train of CLs that deprecates ScopedComPtr in favor of ComPtr. BUG=638327 ========== to ========== Remove Base Class from ScopedComPtr and Deprecate Removed scoped_refptr as a superclass of ScopedComPtr and inlined necessary methods scoped_refptr from to keep the build compiling. This also starts the train of CLs that deprecates ScopedComPtr in favor of ComPtr. BUG=638327 Review-Url: https://codereview.chromium.org/2787123006 Cr-Commit-Position: refs/heads/master@{#461531} Committed: https://chromium.googlesource.com/chromium/src/+/c2bea96144eaa81bf54ac4a341a9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c2bea96144eaa81bf54ac4a341a9... |
