Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2787103002: Added a test in response to Issue 2747813006 (Closed)

Created:
3 years, 8 months ago by lunalu1
Modified:
3 years, 8 months ago
Reviewers:
ortuno, qyearsley, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added a test in response to Issue 2747813006 (https://codereview.chromium.org/2747813006/) and upstreamed it to wpt BUG=701562 Review-Url: https://codereview.chromium.org/2787103002 Cr-Commit-Position: refs/heads/master@{#461284} Committed: https://chromium.googlesource.com/chromium/src/+/7e883e151b6e43336ff4252a14212fe61d2605f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
D third_party/WebKit/LayoutTests/bluetooth/idl/idl-Bluetooth.html View 1 chunk +0 lines, -16 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/bluetooth/idl-Bluetooth.html View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
lunalu1
PTAL
3 years, 8 months ago (2017-03-30 19:18:21 UTC) #4
ortuno
Thanks! lgtm
3 years, 8 months ago (2017-03-30 23:02:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787103002/1
3 years, 8 months ago (2017-03-31 21:38:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7e883e151b6e43336ff4252a14212fe61d2605f8
3 years, 8 months ago (2017-04-01 00:17:28 UTC) #13
ortuno
qyearsley, jeffcarp: This CL added a file to external/wpt. As per instructions in [1] I ...
3 years, 8 months ago (2017-04-02 23:31:06 UTC) #15
qyearsley
On 2017/04/02 at 23:31:06, ortuno wrote: > qyearsley, jeffcarp: This CL added a file to ...
3 years, 8 months ago (2017-04-03 15:14:05 UTC) #16
jeffcarp
3 years, 8 months ago (2017-04-03 17:58:52 UTC) #17
Message was sent while issue was closed.
On 2017/04/03 at 15:14:05, qyearsley wrote:
> On 2017/04/02 at 23:31:06, ortuno wrote:
> > qyearsley, jeffcarp: This CL added a file to external/wpt. As per
instructions in [1] I was expecting a PR for the Github repo but I can't seem to
find any PRs[2] and the file doesn't exist in master either[3]. Did we miss a
step for upstreaming our test?
> > 
> > [1]
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat...
> > [2]
https://github.com/w3c/web-platform-tests/pulls?page=2&q=is%3Apr+label%3Achro...
> > [3] https://github.com/w3c/web-platform-tests
> 
> You didn't miss a step, I think that the exporter has been blocked:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwp...
> 
> Today we should look into this and unblock it.

Apologies, the Sync process was blocked for a bit. A PR has been created:
https://github.com/w3c/web-platform-tests/pull/5323

Powered by Google App Engine
This is Rietveld 408576698