Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2787083002: [Media Router] Center the text on Cast/Stop buttons in the route details view (Closed)

Created:
3 years, 8 months ago by takumif
Modified:
3 years, 8 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Center the text on Cast/Stop buttons in the route details view In the route details view, when the user presses on the Cast/Stop buttons they can see that the buttons' text isn't centered. This CL changes the CSS to fix that. BUG=647778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2787083002 Cr-Commit-Position: refs/heads/master@{#461182} Committed: https://chromium.googlesource.com/chromium/src/+/8e51c4ddf8ef5cf7569304badb23a60487ec3e09

Patch Set 1 #

Patch Set 2 : Remove whitespace #

Patch Set 3 : Support RTL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/resources/media_router/elements/route_details/route_details.css View 1 2 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
takumif
Please take a look. I've checked manually on Linux/Mac/Win. You can see the before/after screenshots ...
3 years, 8 months ago (2017-03-30 19:35:35 UTC) #5
apacible
Please also attach screenshots for RTL and with long press on "stop". Thanks!
3 years, 8 months ago (2017-03-30 22:00:49 UTC) #6
takumif
On 2017/03/30 22:00:49, apacible wrote: > Please also attach screenshots for RTL and with long ...
3 years, 8 months ago (2017-03-30 23:52:31 UTC) #8
apacible
On 2017/03/30 23:52:31, takumif wrote: > On 2017/03/30 22:00:49, apacible wrote: > > Please also ...
3 years, 8 months ago (2017-03-31 06:11:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787083002/60001
3 years, 8 months ago (2017-03-31 19:17:13 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 19:31:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8e51c4ddf8ef5cf7569304badb23...

Powered by Google App Engine
This is Rietveld 408576698