Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2787033002: Remove broken focusout listener for System Security Setting OOBE dialog (Closed)

Created:
3 years, 8 months ago by Greg Levin
Modified:
3 years, 8 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove broken focusout listener for System Security Setting OOBE dialog BUG=690726 TEST=In new MD OOBE, advance to Chrome OS Terms page, click "System security setting". Turn on ChromeVox, check that CV nav keys can highlight and read dialog contents. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2787033002 Cr-Commit-Position: refs/heads/master@{#460899} Committed: https://chromium.googlesource.com/chromium/src/+/f9baf94fc70de8725932d3421fafa85db3d3cfbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_eula.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Greg Levin
This focusout listener was preventing SHIFT+TAB, but not TAB, from moving focus off the dialog. ...
3 years, 8 months ago (2017-03-30 17:17:20 UTC) #3
Greg Levin
(achuith@ - please have a look!)
3 years, 8 months ago (2017-03-30 17:17:54 UTC) #4
achuithb
lgtm. Looks like this was introduced more than 4 years ago over here: https://chromiumcodereview.appspot.com/11412067 There's ...
3 years, 8 months ago (2017-03-30 20:20:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787033002/1
3 years, 8 months ago (2017-03-30 20:26:34 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:55:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9baf94fc70de8725932d3421faf...

Powered by Google App Engine
This is Rietveld 408576698