Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 278703002: Initial mojo spy skeleton based on tvcm (Closed)

Created:
6 years, 7 months ago by nduca
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Initial mojo spy skeleton based on tvcm R=cpu

Patch Set 1 #

Patch Set 2 : ready to land #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -29 lines) Patch
A + mojo/spy/PRESUBMIT.py View 1 chunk +2 lines, -21 lines 1 comment Download
A mojo/spy/run_ui_dev_server View 1 1 chunk +22 lines, -0 lines 1 comment Download
A mojo/spy/run_ui_tests View 1 chunk +23 lines, -0 lines 0 comments Download
A + mojo/spy/ui/__init__.py View 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/spy/ui/dev_server.py View 1 chunk +5 lines, -5 lines 0 comments Download
A mojo/spy/ui/spy.html View 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy.js View 1 chunk +96 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_project.py View 1 chunk +18 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_shell.html View 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_shell.js View 1 chunk +68 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_shell_to_html View 1 chunk +13 lines, -0 lines 0 comments Download
A mojo/spy/ui/spy_shell_to_html.py View 1 chunk +39 lines, -0 lines 1 comment Download
A mojo/spy/ui/spy_test.js View 1 chunk +51 lines, -0 lines 0 comments Download
A mojo/spy/ui/tvcm_stub.py View 1 chunk +18 lines, -0 lines 0 comments Download
A + mojo/spy/ui/ui_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nat
so this i think mostly works. maybe we should chat about whats in here, its ...
6 years, 7 months ago (2014-05-08 22:54:47 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 7 months ago (2014-05-09 17:48:19 UTC) #2
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 7 months ago (2014-05-09 17:50:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/278703002/20001
6 years, 7 months ago (2014-05-09 17:56:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 20:03:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 20:22:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66885)
6 years, 7 months ago (2014-05-09 20:22:30 UTC) #7
cpu_(ooo_6.6-7.5)
vtl, can you please review?
6 years, 7 months ago (2014-05-12 18:07:56 UTC) #8
viettrungluu
6 years, 7 months ago (2014-05-12 19:07:33 UTC) #9
I have no idea what I'm looking at, but if it's good enough for cpu it's good
enough for me (other than stupid copyright message nits). LGTM.

https://codereview.chromium.org/278703002/diff/20001/mojo/spy/PRESUBMIT.py
File mojo/spy/PRESUBMIT.py (right):

https://codereview.chromium.org/278703002/diff/20001/mojo/spy/PRESUBMIT.py#ne...
mojo/spy/PRESUBMIT.py:1: # Copyright (c) 2012 The Chromium Authors. All rights
reserved.
Nit: 2014.

Also, the current copyright notice doesn't have the "(c)".

https://codereview.chromium.org/278703002/diff/20001/mojo/spy/run_ui_dev_server
File mojo/spy/run_ui_dev_server (right):

https://codereview.chromium.org/278703002/diff/20001/mojo/spy/run_ui_dev_serv...
mojo/spy/run_ui_dev_server:2: # Copyright (c) 2014 The Chromium Authors. All
rights reserved.
(Etc.) ... I'm on an OCD-driven mission to eradicate the (c)'s.

https://codereview.chromium.org/278703002/diff/20001/mojo/spy/ui/spy_shell_to...
File mojo/spy/ui/spy_shell_to_html.py (right):

https://codereview.chromium.org/278703002/diff/20001/mojo/spy/ui/spy_shell_to...
mojo/spy/ui/spy_shell_to_html.py:38: title='Mojo spy',
nit: indentation

Powered by Google App Engine
This is Rietveld 408576698