Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: mojo/spy/PRESUBMIT.py

Issue 278703002: Initial mojo spy skeleton based on tvcm (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ready to land Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/spy/run_ui_dev_server » ('j') | mojo/spy/run_ui_dev_server » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/spy/PRESUBMIT.py
diff --git a/tools/telemetry/PRESUBMIT.py b/mojo/spy/PRESUBMIT.py
similarity index 58%
copy from tools/telemetry/PRESUBMIT.py
copy to mojo/spy/PRESUBMIT.py
index e7b66d64c922a86d2dc1febd6296914971fb685d..bd902a448d571c354ae21ccd54b38acafefebf10 100644
--- a/tools/telemetry/PRESUBMIT.py
+++ b/mojo/spy/PRESUBMIT.py
@@ -4,32 +4,13 @@
import os
import sys
-PYLINT_BLACKLIST = []
-PYLINT_DISABLED_WARNINGS = ['R0923', 'R0201', 'E1101']
-
def _CommonChecks(input_api, output_api):
results = []
-
- # TODO(nduca): This should call update_docs.IsUpdateDocsNeeded().
- # Disabled due to crbug.com/255326.
- if False:
- update_docs_path = os.path.join(
- input_api.PresubmitLocalPath(), 'update_docs')
- assert os.path.exists(update_docs_path)
- results.append(output_api.PresubmitError(
- 'Docs are stale. Please run:\n' +
- '$ %s' % os.path.abspath(update_docs_path)))
-
- # Importing telemetry.web_components actually brings tvcm into the path.
- import telemetry.web_components # pylint: disable=W0612
+ # Importing ui actually brings tvcm into the path.
+ import ui
from tvcm import presubmit_checker
checker = presubmit_checker.PresubmitChecker(input_api, output_api)
results += checker.RunChecks()
-
- results.extend(input_api.canned_checks.RunPylint(
- input_api, output_api,
- black_list=PYLINT_BLACKLIST,
- disabled_warnings=PYLINT_DISABLED_WARNINGS))
return results
def GetPathsToPrepend(input_api):
« no previous file with comments | « no previous file | mojo/spy/run_ui_dev_server » ('j') | mojo/spy/run_ui_dev_server » ('J')

Powered by Google App Engine
This is Rietveld 408576698