Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2787013003: [Sensors] Adding more UMA histogram values (Closed)

Created:
3 years, 8 months ago by Mikhail
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, shalamov, wanming.lin, blink-reviews, blink-reviews-frames_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Adding more UMA histogram values This CL adds more UMA histogram values to track concrete sensor construction and better cover Generic Sensor API. BUG=606766 Review-Url: https://codereview.chromium.org/2787013003 Cr-Commit-Position: refs/heads/master@{#461398} Committed: https://chromium.googlesource.com/chromium/src/+/debbdccc88833a2d4c1e03a616f20566e0d0e618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/AbsoluteOrientationSensor.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/AmbientLightSensor.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Gyroscope.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Magnetometer.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/OrientationSensor.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Mikhail
PTAL
3 years, 8 months ago (2017-03-31 14:47:00 UTC) #5
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-03-31 18:36:43 UTC) #8
haraken
LGTM
3 years, 8 months ago (2017-03-31 23:10:42 UTC) #9
shalamov
lgtm
3 years, 8 months ago (2017-04-03 07:52:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787013003/1
3 years, 8 months ago (2017-04-03 08:02:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787013003/1
3 years, 8 months ago (2017-04-03 09:28:46 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 09:50:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/debbdccc88833a2d4c1e03a616f2...

Powered by Google App Engine
This is Rietveld 408576698