Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2786993004: Change builder config so that android also uses specific version names. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jbudorick
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change builder config so that android also uses specific version names. This would make it so that the entries for the android builders (continuous and try bot) have a specific version in the port name and specifier. This shouldn't change behavior when running the tests, I believe. The original motivation for this change was to make it so that the update-test-expectations script finds the android builder correctly. That script iterates through all possible configurations and finds builders that match; previously it was trying to find any builder that matched the specific port "icecreamsandwich" but was unable to find any android builder that matched since there was none in common/config/builders.py. BUG=705593 Review-Url: https://codereview.chromium.org/2786993004 Cr-Commit-Position: refs/heads/master@{#461160} Committed: https://chromium.googlesource.com/chromium/src/+/10680ded1bf7a68d8f9a05dd8dd9b378817bbe1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
qyearsley
3 years, 8 months ago (2017-03-31 00:54:36 UTC) #4
jbudorick
lgtm
3 years, 8 months ago (2017-03-31 15:31:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786993004/1
3 years, 8 months ago (2017-03-31 17:17:40 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 17:29:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10680ded1bf7a68d8f9a05dd8dd9...

Powered by Google App Engine
This is Rietveld 408576698