Render focus-selection-textarea at constant font-size to avoid flakiness

Render focus-selection-textarea at constant font-size to avoid flakiness

When crrev.com/453211 updated FreeType on Linux, some glyphs 
got bigger due to the new antialiasing and hinting settings.

Bigger glyphs made focus-selection-textarea.html layout differently.
With the new layout, scripted mouse clicks no longer hit the right spot.

After the manual rebaselining in crrev.com/453211, the expected result
on Linux started to include FAIL whereas other platforms still expected
PASS. This CL makes also Linux PASS.

BUG=706119, 274030
TEST=python third_party/WebKit/Tools/Scripts/run-webkit-tests -t\
     PcDebug LayoutTests/fast/forms/focus-selection-textarea.html

Review-Url: https://codereview.chromium.org/2786953002
Cr-Commit-Position: refs/heads/master@{#460732}
Committed: https://chromium.googlesource.com/chromium/src/+/3afa26135e229e0f7fb81328a2bf4dcf966f90af

[hugoh_UTC2, 2017-03-30 10:15:18]

hugoh@opera.com changed reviewers:
+ finnur@chromium.org

[hugoh_UTC2, 2017-03-30 10:15:19]

finnur@ PTAL

Hopefully the rebaselining will fix crbug.com/706119 (unless the Windows
environment itself is flaky that is). 

While at this test, I also fixed the inconsistency between Linux and the other
platforms.

[drott, 2017-03-30 10:34:21]

Hi, thanks for fixing this and sorry if I missed this in the large rebaseline. I
believe the default font size did not change, but with the newer FreeType the
rendered width changes in some cases due to different antialiasing and hinting
settings.

[hugoh_UTC2, 2017-03-30 10:40:21]

On 2017/03/30 10:34:21, drott wrote:
> Hi, thanks for fixing this and sorry if I missed this in the large rebaseline.
I
> believe the default font size did not change, but with the newer FreeType the
> rendered width changes in some cases due to different antialiasing and hinting
> settings.

Thanks, ah yes, I did not visually investigate how the rendered glyphs changed
exactly. But I guess that the new antialiasing and hinting grew the glyphs
somewhat. Thus affecting the layout.

[hugoh_UTC2, 2017-03-30 10:47:07]

Description was changed from

==========
Render focus-selection-textarea at constant font-size to avoid flakiness

When crrev.com/453211 updated FreeType on Linux, the default font-size
changed. The new default font-size made focus-selection-textarea.html
layout differently. With the new layout, scripted mouse clicks no longer
hit the right spot.

After the manual rebaselining in crrev.com/453211, the expected result
on Linux started to include FAIL whereas other platforms still expected
PASS. This CL makes also Linux PASS.

BUG=706119, 274030

TEST=python third_party/WebKit/Tools/Scripts/run-webkit-tests -t\
     PcDebug LayoutTests/fast/forms/focus-selection-textarea.html
==========

to

==========
Render focus-selection-textarea at constant font-size to avoid flakiness

When crrev.com/453211 updated FreeType on Linux, some glyphs 
got bigger due to the new antialiasing and hinting settings.

Bigger glyphs made focus-selection-textarea.html layout differently.
With the new layout, scripted mouse clicks no longer hit the right spot.

After the manual rebaselining in crrev.com/453211, the expected result
on Linux started to include FAIL whereas other platforms still expected
PASS. This CL makes also Linux PASS.

BUG=706119, 274030

TEST=python third_party/WebKit/Tools/Scripts/run-webkit-tests -t\
     PcDebug LayoutTests/fast/forms/focus-selection-textarea.html
==========

[Finnur, 2017-03-30 11:04:43]

LGTM

[hugoh_UTC2, 2017-03-30 11:08:03]

The CQ bit was checked by hugoh@opera.com

[commit-bot: I haz the power, 2017-03-30 11:08:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 12:29:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490872083258060, "parent_rev":
"24939285bd24532cc0c2ffca609c5e80073cd9f4", "commit_rev":
"3afa26135e229e0f7fb81328a2bf4dcf966f90af"}

[commit-bot: I haz the power, 2017-03-30 12:29:56]

Description was changed from

==========
Render focus-selection-textarea at constant font-size to avoid flakiness

When crrev.com/453211 updated FreeType on Linux, some glyphs 
got bigger due to the new antialiasing and hinting settings.

Bigger glyphs made focus-selection-textarea.html layout differently.
With the new layout, scripted mouse clicks no longer hit the right spot.

After the manual rebaselining in crrev.com/453211, the expected result
on Linux started to include FAIL whereas other platforms still expected
PASS. This CL makes also Linux PASS.

BUG=706119, 274030

TEST=python third_party/WebKit/Tools/Scripts/run-webkit-tests -t\
     PcDebug LayoutTests/fast/forms/focus-selection-textarea.html
==========

to

==========
Render focus-selection-textarea at constant font-size to avoid flakiness

When crrev.com/453211 updated FreeType on Linux, some glyphs 
got bigger due to the new antialiasing and hinting settings.

Bigger glyphs made focus-selection-textarea.html layout differently.
With the new layout, scripted mouse clicks no longer hit the right spot.

After the manual rebaselining in crrev.com/453211, the expected result
on Linux started to include FAIL whereas other platforms still expected
PASS. This CL makes also Linux PASS.

BUG=706119, 274030

TEST=python third_party/WebKit/Tools/Scripts/run-webkit-tests -t\
     PcDebug LayoutTests/fast/forms/focus-selection-textarea.html

Review-Url: https://codereview.chromium.org/2786953002
Cr-Commit-Position: refs/heads/master@{#460732}
Committed:
https://chromium.googlesource.com/chromium/src/+/3afa26135e229e0f7fb81328a2bf...
==========

[commit-bot: I haz the power, 2017-03-30 12:29:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3afa26135e229e0f7fb81328a2bf...