Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2786943003: [Mac] Fix a potential crash in the permission bubble controller (Closed)

Created:
3 years, 8 months ago by spqchan
Modified:
3 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix a potential crash in the permission bubble controller BUG=706489 Review-Url: https://codereview.chromium.org/2786943003 Cr-Commit-Position: refs/heads/master@{#460948} Committed: https://chromium.googlesource.com/chromium/src/+/2b0f410e97c2f08f08f3e162bc995c7c4c237970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
spqchan
PTAL
3 years, 8 months ago (2017-03-30 23:32:07 UTC) #7
Avi (use Gerrit)
lgtm
3 years, 8 months ago (2017-03-30 23:40:31 UTC) #8
spqchan
On 2017/03/30 23:40:31, Avi wrote: > lgtm thanks!
3 years, 8 months ago (2017-03-30 23:41:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786943003/1
3 years, 8 months ago (2017-03-30 23:43:10 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 00:21:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b0f410e97c2f08f08f3e162bc99...

Powered by Google App Engine
This is Rietveld 408576698