Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2786943002: Fix progress and timeout dialog for getting account management policy (Closed)

Created:
3 years, 8 months ago by bsazonov
Modified:
3 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix progress and timeout dialog for getting account management policy This CL fixes two issues introduced by https://crrev.com/2772203004 1. Bottom padding of dialog content for progress dialog. This CL replaces manual padding control with AlertDialogContent style. 2. Retry button behavior in timeout dialog: it wasn't showing progress dialog again because of a bug introduced during review. BUG=650121 Review-Url: https://codereview.chromium.org/2786943002 Cr-Commit-Position: refs/heads/master@{#461108} Committed: https://chromium.googlesource.com/chromium/src/+/c1eda31a97825bb7504ca74b5b14a6cfc73de03d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M chrome/android/java/res/layout/signin_progress_bar_dialog.xml View 1 chunk +3 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
bsazonov
Bernhard, could you please take a look?
3 years, 8 months ago (2017-03-31 08:24:53 UTC) #2
Bernhard Bauer
lgtm
3 years, 8 months ago (2017-03-31 09:11:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786943002/1
3 years, 8 months ago (2017-03-31 13:51:21 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 13:56:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1eda31a97825bb7504ca74b5b14...

Powered by Google App Engine
This is Rietveld 408576698