Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2786933002: [regexp] Only access result.groups if named captures are enabled (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Only access result.groups if named captures are enabled GetProperty(result, groups) needs to be called iff the harmony-regexp-named-captures flag is enabled. Also add a couple of DCHECKS. BUG=v8:5437, chromium:706748 Review-Url: https://codereview.chromium.org/2786933002 Cr-Commit-Position: refs/heads/master@{#44267} Committed: https://chromium.googlesource.com/v8/v8/+/1200cc2c6d715466ee762a05ae26fe4a4f82eb36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/runtime/runtime-regexp.cc View 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 8 months ago (2017-03-30 09:45:32 UTC) #4
Yang
lgtm
3 years, 8 months ago (2017-03-30 11:50:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786933002/1
3 years, 8 months ago (2017-03-30 11:53:59 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 11:55:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1200cc2c6d715466ee762a05ae26fe4a4f8...

Powered by Google App Engine
This is Rietveld 408576698