[LayoutNG] WIP on storing layout output in the legacy tree for multicol.

[LayoutNG] WIP on storing layout output in the legacy tree for multicol.

Painting NG fragment trees is still not supported, so in the meantime
we'll keep LayoutMultiColumnFlowThread and LayoutMultiColumnSet, and have
multicol painted and hit-tested in the old-fashioned way (just like
everything else, really).

Based on work by glebl.

BUG=635619
Review-Url: https://codereview.chromium.org/2786923004
Cr-Commit-Position: refs/heads/master@{#461409}
Committed: https://chromium.googlesource.com/chromium/src/+/46ad4aca1dbb7184ebfae2a42fb41aa510eb3bcc

[Gleb Lanbin, 2017-03-31 22:33:28]

glebl@chromium.org changed reviewers:
+ glebl@chromium.org

[Gleb Lanbin, 2017-03-31 22:33:29]

thank you! Do you think we can submit the change in ng_block_node.cc? Please
revert the rest. lgtm

https://codereview.chromium.org/2786923004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):

https://codereview.chromium.org/2786923004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:244: LayoutBlockFlow*
multicol = toLayoutBlockFlow(layout_box_);
can you move this logic into a separate function declared in the unnamed
namespace, e.g. UpdateLegacyMultiFlowThread?

if (layout_box_->style()->specifiesColumns())
  UpdateLegacyMultiFlowThread(layout_box_, fragment);

[Gleb Lanbin, 2017-03-31 22:35:13]

On 2017/03/31 22:33:29, Gleb Lanbin wrote:
> thank you! Do you think we can submit the change in ng_block_node.cc? Please
> revert the rest. lgtm
> 
>
https://codereview.chromium.org/2786923004/diff/120001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):
> 
>
https://codereview.chromium.org/2786923004/diff/120001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:244:
LayoutBlockFlow*
> multicol = toLayoutBlockFlow(layout_box_);
> can you move this logic into a separate function declared in the unnamed
> namespace, e.g. UpdateLegacyMultiFlowThread?
> 
> if (layout_box_->style()->specifiesColumns())
>   UpdateLegacyMultiFlowThread(layout_box_, fragment);

If you're OK to submit this then please fix the patch's description and add a
bug number(635619)

[mstensho (USE GERRIT), 2017-04-03 10:01:35]

Description was changed from

==========
Paint multicol from LayoutNG

BUG=

patch from issue 2786253002 at patchset 1 (http://crrev.com/2786253002#ps1)
==========

to

==========
Paint multicol from LayoutNG

BUG=635619
==========

[mstensho (USE GERRIT), 2017-04-03 10:05:41]

Description was changed from

==========
Paint multicol from LayoutNG

BUG=635619
==========

to

==========
[LayoutNG] Work on storing layout output in the legacy tree for multicol.

Painting NG fragment trees is still not supported, so in the meantime
we'll keep LayoutMultiColumnFlowThread and LayoutMultiColumnSet.

Some changes here are based on work by glebl.

BUG=635619
==========

[mstensho (USE GERRIT), 2017-04-03 10:11:00]

On 2017/03/31 22:33:29, Gleb Lanbin wrote:
> thank you! Do you think we can submit the change in ng_block_node.cc? Please
> revert the rest. lgtm

Ok, but I'm keeping the changes in LayoutBlockFlow.cpp too, so that we actually
create the flow thread in NG, to meet the expectations of the new code in
ng_block_node.cc.

[mstensho (USE GERRIT), 2017-04-03 10:20:11]

https://codereview.chromium.org/2786923004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):

https://codereview.chromium.org/2786923004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:244: LayoutBlockFlow*
multicol = toLayoutBlockFlow(layout_box_);
On 2017/03/31 22:33:29, Gleb Lanbin wrote:
> can you move this logic into a separate function declared in the unnamed
> namespace, e.g. UpdateLegacyMultiFlowThread?
> 
> if (layout_box_->style()->specifiesColumns())
>   UpdateLegacyMultiFlowThread(layout_box_, fragment);

Done.

[mstensho (USE GERRIT), 2017-04-03 10:22:10]

Description was changed from

==========
[LayoutNG] Work on storing layout output in the legacy tree for multicol.

Painting NG fragment trees is still not supported, so in the meantime
we'll keep LayoutMultiColumnFlowThread and LayoutMultiColumnSet.

Some changes here are based on work by glebl.

BUG=635619
==========

to

==========
[LayoutNG] WIP on storing layout output in the legacy tree for multicol.

Painting NG fragment trees is still not supported, so in the meantime
we'll keep LayoutMultiColumnFlowThread and LayoutMultiColumnSet, and have
multicol painted and hit-tested in the old-fashioned way (just like
everything else, really).

Based on work by glebl.

BUG=635619
==========

[mstensho (USE GERRIT), 2017-04-03 10:40:56]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2017-04-03 10:40:57]

The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org
Link to the patchset: https://codereview.chromium.org/2786923004/#ps200001
(title: "Move stuff to UpdateLegacyMultiColumnFlowThread()")

[commit-bot: I haz the power, 2017-04-03 10:41:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 12:06:35]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1491216056903270,
"parent_rev": "51e2977044591f818e84c297e5dec72c639f465f", "commit_rev":
"46ad4aca1dbb7184ebfae2a42fb41aa510eb3bcc"}

[commit-bot: I haz the power, 2017-04-03 12:07:25]

Description was changed from

==========
[LayoutNG] WIP on storing layout output in the legacy tree for multicol.

Painting NG fragment trees is still not supported, so in the meantime
we'll keep LayoutMultiColumnFlowThread and LayoutMultiColumnSet, and have
multicol painted and hit-tested in the old-fashioned way (just like
everything else, really).

Based on work by glebl.

BUG=635619
==========

to

==========
[LayoutNG] WIP on storing layout output in the legacy tree for multicol.

Painting NG fragment trees is still not supported, so in the meantime
we'll keep LayoutMultiColumnFlowThread and LayoutMultiColumnSet, and have
multicol painted and hit-tested in the old-fashioned way (just like
everything else, really).

Based on work by glebl.

BUG=635619

Review-Url: https://codereview.chromium.org/2786923004
Cr-Commit-Position: refs/heads/master@{#461409}
Committed:
https://chromium.googlesource.com/chromium/src/+/46ad4aca1dbb7184ebfae2a42fb4...
==========

[commit-bot: I haz the power, 2017-04-03 12:07:26]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/46ad4aca1dbb7184ebfae2a42fb4...