Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2786903002: [innerText] Add more tests to setter.html. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[innerText] Add more tests to setter.html. - Test WebKit's quirky behavior - Test that TEXTAREA isn't special BUG=705478 Review-Url: https://codereview.chromium.org/2786903002 Cr-Commit-Position: refs/heads/master@{#460701} Committed: https://chromium.googlesource.com/chromium/src/+/e8cf8925a1f9bf3fc2b428b56e8565ef2c008c3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/innerText/setter.html View 2 chunks +52 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/innerText/setter-expected.txt View 1 chunk +69 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/innerText/setter-tests.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
yosin@, would you review this please?
3 years, 8 months ago (2017-03-30 08:02:18 UTC) #5
yosin_UTC9
lgtm
3 years, 8 months ago (2017-03-30 08:48:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786903002/1
3 years, 8 months ago (2017-03-30 08:48:37 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 08:53:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8cf8925a1f9bf3fc2b428b56e85...

Powered by Google App Engine
This is Rietveld 408576698