Let RangeBoundaryPoint::toPoisition return Position not considering Editing

Let RangeBoundaryPoint::toPoisition return Position not considering Editing

In the very beginning, we used this function in Editing context.
However it seems we don't use this in Editing directly.
In addition, it is natural that RangeBoundaryPoint don't consider Editability.

Review-Url: https://codereview.chromium.org/2786853002
Cr-Commit-Position: refs/heads/master@{#462000}
Committed: https://chromium.googlesource.com/chromium/src/+/c641d7f15bcf95e6779706e06780f8b581f2dc35

[yoichio, 2017-03-30 02:34:10]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 02:34:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-30 04:09:39]

Description was changed from

==========
RangeBoundaryPoint::toPoisition just return Position no Editing

BUG=
==========

to

==========
Let RangeBoundaryPoint::toPoisition return Position not considering Editing

In the very beginning, we used this function in Editing context.
However it seems we don't use this in Editing directly.
In addition, it is natural that RangeBoundaryPoint don't consider Editability.
==========

[yoichio, 2017-03-30 04:09:39]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[commit-bot: I haz the power, 2017-03-30 04:10:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 04:10:19]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-30 05:44:58]

lgtm w/ nit

https://codereview.chromium.org/2786853002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h (left):

https://codereview.chromium.org/2786853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h:132: // TODO(yosin): We
should return |Position::beforeAnchor| when
Could you keep this TODO? We still want to return |Position::beforeAnchor|.

[yoichio, 2017-03-30 07:00:14]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-03-30 07:00:14]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2786853002/#ps40001
(title: "update")

[commit-bot: I haz the power, 2017-03-30 07:00:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-30 07:02:46]

The CQ bit was unchecked by yoichio@chromium.org

[yoichio, 2017-03-30 07:04:09]

https://codereview.chromium.org/2786853002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h (left):

https://codereview.chromium.org/2786853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h:132: // TODO(yosin): We
should return |Position::beforeAnchor| when
On 2017/03/30 05:44:58, yosin_UTC9 wrote:
> Could you keep this TODO? We still want to return |Position::beforeAnchor|.
Could you explain why ?

[yoichio, 2017-03-31 06:00:39]

On 2017/03/30 07:04:09, yoichio wrote:
>
https://codereview.chromium.org/2786853002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h (left):
> 
>
https://codereview.chromium.org/2786853002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h:132: // TODO(yosin):
We
> should return |Position::beforeAnchor| when
> On 2017/03/30 05:44:58, yosin_UTC9 wrote:
> > Could you keep this TODO? We still want to return |Position::beforeAnchor|.
> Could you explain why ?
PTAL

[yoichio, 2017-03-31 09:31:40]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-03-31 09:31:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 09:38:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 09:38:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoichio, 2017-04-03 01:45:29]

yoichio@chromium.org changed reviewers:
+ tkent@chromium.org

[yoichio, 2017-04-03 01:45:29]

tkent, PTAL.

[tkent, 2017-04-03 04:08:21]

Does this have a behavior change?
If so, please add a test.

[yoichio, 2017-04-04 04:16:25]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 04:16:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 07:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 07:22:22]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yoichio, 2017-04-05 02:08:40]

On 2017/04/03 04:08:21, tkent wrote:
> Does this have a behavior change?
> If so, please add a test.

Done. PTAL.

[tkent, 2017-04-05 02:26:32]

lgtm

[yoichio, 2017-04-05 02:32:08]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-04-05 02:32:08]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2786853002/#ps80001
(title: "Add test")

[commit-bot: I haz the power, 2017-04-05 02:33:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 02:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:42:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoichio, 2017-04-05 05:17:44]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-04-05 05:17:44]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2786853002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-05 05:17:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 07:25:13]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491369464430100,
"parent_rev": "ebb66ffb22611d7cc1a50711b0c3eb5a609a5a79", "commit_rev":
"c641d7f15bcf95e6779706e06780f8b581f2dc35"}

[commit-bot: I haz the power, 2017-04-05 07:26:31]

Description was changed from

==========
Let RangeBoundaryPoint::toPoisition return Position not considering Editing

In the very beginning, we used this function in Editing context.
However it seems we don't use this in Editing directly.
In addition, it is natural that RangeBoundaryPoint don't consider Editability.
==========

to

==========
Let RangeBoundaryPoint::toPoisition return Position not considering Editing

In the very beginning, we used this function in Editing context.
However it seems we don't use this in Editing directly.
In addition, it is natural that RangeBoundaryPoint don't consider Editability.

Review-Url: https://codereview.chromium.org/2786853002
Cr-Commit-Position: refs/heads/master@{#462000}
Committed:
https://chromium.googlesource.com/chromium/src/+/c641d7f15bcf95e6779706e06780...
==========

[commit-bot: I haz the power, 2017-04-05 07:26:34]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c641d7f15bcf95e6779706e06780...