Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h

Issue 2786843002: Make HeapObjectHeader::checkHeader private. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
index 090fdde39dec71067752c04da5f7e6fa22564296..7a61c175584a7c91cae11de6a20a8d2b11a5160f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
+++ b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
@@ -27,7 +27,8 @@ class TraceWrapperMember : public Member<T> {
TraceWrapperMember(void* parent, T* raw) : Member<T>(raw), m_parent(parent) {
#if DCHECK_IS_ON()
if (m_parent) {
- HeapObjectHeader::fromPayload(m_parent)->checkHeader();
+ // |fromPayload| checks the integrity of the |HeapObjectHeader|.
+ (void)HeapObjectHeader::fromPayload(m_parent);
haraken 2017/03/30 14:12:46 I'd prefer having HeapObjectHeader::checkHeader()
}
#endif
// We don't require a write barrier here as TraceWrapperMember is used for
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/GCInfo.cpp » ('j') | third_party/WebKit/Source/platform/heap/HeapPage.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698