Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2786833002: Re-enable BrowserCloseManagerBrowserTest.AddBeforeUnloadDuringClosing. (Closed)

Created:
3 years, 8 months ago by Avi (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable BrowserCloseManagerBrowserTest.AddBeforeUnloadDuringClosing. It started flaking about the time that the beforeunload timer was split off, a bug that was just fixed in 64b8b65b733a3ac8bd0b5f707431f6d1fae20948. BUG=700271 TEST=stays green, doesn't flake Review-Url: https://codereview.chromium.org/2786833002 Cr-Commit-Position: refs/heads/master@{#460651} Committed: https://chromium.googlesource.com/chromium/src/+/48d2fdd58a870311125af22464402ffd7e74db50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 8 months ago (2017-03-30 01:13:25 UTC) #4
Nico
Lgtm
3 years, 8 months ago (2017-03-30 01:51:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786833002/1
3 years, 8 months ago (2017-03-30 03:43:46 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:51:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48d2fdd58a870311125af2246440...

Powered by Google App Engine
This is Rietveld 408576698