Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2786803002: Add a ContentVerifyJob test for sanity checking legitimate 0 byte file. (Closed)

Created:
3 years, 8 months ago by lazyboy
Modified:
3 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a ContentVerifyJob test for sanity checking legitimate 0 byte file. There is no restriction that an extension can upload zero byte resource. Add a test to test that behavior to make sure content verificaton works as expected. Take the opportunity to refactor repeated code into RunContentVerifyJob function. BUG=703888 Test=No visible change. Review-Url: https://codereview.chromium.org/2786803002 Cr-Commit-Position: refs/heads/master@{#460685} Committed: https://chromium.googlesource.com/chromium/src/+/6665648f820bad8de48fc0699ba315696b6dd127

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -70 lines) Patch
M extensions/browser/content_verify_job_unittest.cc View 5 chunks +80 lines, -70 lines 0 comments Download
A extensions/test/data/content_hash_fetcher/zero_byte_file/README.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A extensions/test/data/content_hash_fetcher/zero_byte_file/source.zip View Binary file 0 comments Download

Messages

Total messages: 13 (9 generated)
lazyboy
3 years, 8 months ago (2017-03-29 21:23:38 UTC) #2
Devlin
lgtm!
3 years, 8 months ago (2017-03-29 22:34:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786803002/20001
3 years, 8 months ago (2017-03-30 07:03:42 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 07:08:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6665648f820bad8de48fc0699ba3...

Powered by Google App Engine
This is Rietveld 408576698