Roll closure compiler

Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e068050651af27bccdfa...f9c738eb53fb5cd1d475871ef16c6d1cca19b815
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 -> 04dad454b5797074b803c0bab27f1aa87e19d562

BUG=699302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
R=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2786793002 .
Cr-Commit-Position: refs/heads/master@{#460617}
Committed: https://chromium.googlesource.com/chromium/src/+/76f1910f47754bd6ff8aa1666b5eb2c3760fd106

[dpapad, 2017-03-29 20:45:51]

Description was changed from

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e06805...
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 ->
04dad454b5797074b803c0bab27f1aa87e19d562

TBR=
BUG=
==========

to

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e06805...
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 ->
04dad454b5797074b803c0bab27f1aa87e19d562

TBR=
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-29 20:46:16]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 20:47:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 20:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 20:51:22]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2017-03-29 21:49:48]

Description was changed from

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e06805...
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 ->
04dad454b5797074b803c0bab27f1aa87e19d562

TBR=
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e06805...
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 ->
04dad454b5797074b803c0bab27f1aa87e19d562

TBR=
BUG=699302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-29 21:52:57]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-03-29 21:52:57]

I had to change the java version requirement to 1.8 in order to run the
roll_closure_compiler script. It seems that 1.8 is more common these days. Both
my workstation and @scottchen's seem to have 1.8. Is there a good reason we
should stick to 1.7?

Regardless of the above, I had to fix some newly find type errors found by JS
Compiler. I can split those to a separate CL if you prefer.

[dpapad, 2017-03-29 22:18:46]

Description was changed from

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e06805...
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 ->
04dad454b5797074b803c0bab27f1aa87e19d562

TBR=
BUG=699302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e06805...
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 ->
04dad454b5797074b803c0bab27f1aa87e19d562

BUG=699302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-29 23:25:31]

On 2017/03/29 21:52:57, dpapad wrote:
> I had to change the java version requirement to 1.8 in order to run the
> roll_closure_compiler script. It seems that 1.8 is more common these days.
Both
> my workstation and @scottchen's seem to have 1.8. Is there a good reason we
> should stick to 1.7?
> 
> Regardless of the above, I had to fix some newly find type errors found by JS
> Compiler. I can split those to a separate CL if you prefer.

the bots have 1.7 I think? you can try running it with 1.8. maybe now that we
have only 1 jar it might work?

[Dan Beam, 2017-03-29 23:27:05]

lgtm

[dpapad, 2017-03-30 01:17:38]

On 2017/03/29 at 23:25:31, dbeam wrote:
> On 2017/03/29 21:52:57, dpapad wrote:
> > I had to change the java version requirement to 1.8 in order to run the
> > roll_closure_compiler script. It seems that 1.8 is more common these days.
Both
> > my workstation and @scottchen's seem to have 1.8. Is there a good reason we
> > should stick to 1.7?
> > 
> > Regardless of the above, I had to fix some newly find type errors found by
JS
> > Compiler. I can split those to a separate CL if you prefer.
> 
> the bots have 1.7 I think? you can try running it with 1.8. maybe now that we
have only 1 jar it might work?

I re-ran roll_closure_compiler script with java 1.7 this time.

[dpapad, 2017-03-30 01:21:49]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-03-30 01:21:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2786793002/#ps40001
(title: "Rerun with java 1.7")

[commit-bot: I haz the power, 2017-03-30 01:22:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-03-30 01:24:45]

On 2017/03/30 at 01:22:26, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

CQ will fail to patch because the of compiler.jar being a binary file. I'll have
to commit this manually.

[commit-bot: I haz the power, 2017-03-30 01:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:26:20]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2017-03-30 01:33:22]

Description was changed from

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e06805...
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 ->
04dad454b5797074b803c0bab27f1aa87e19d562

BUG=699302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Roll closure compiler

Change log:
https://github.com/google/closure-compiler/compare/b2f2d2f3309c7ee61816e06805...
chrome_extensions.js: a3f41820d1260b0d7ed13acac526b803ac6c1870 ->
04dad454b5797074b803c0bab27f1aa87e19d562

BUG=699302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
R=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2786793002 .
Cr-Commit-Position: refs/heads/master@{#460617}
Committed:
https://chromium.googlesource.com/chromium/src/+/76f1910f47754bd6ff8aa1666b5e...
==========

[dpapad, 2017-03-30 01:33:23]

Committed patchset #3 (id:40001) manually as
76f1910f47754bd6ff8aa1666b5eb2c3760fd106 (presubmit successful).