Fix text-align: center/right when line wraps at atomic inline and spaces

Fix text-align: center/right when line wraps at atomic inline and spaces

LayoutBlockFlow::updateLogicalWidthForAlignment() requires
trailingSpaceRun to compute center/right alignment when line wraps at
atomic inline and spaces, but InlineBidiResolver computes
trailingSpaceRun only when UAX#9 L1 is needed. This patch fixes to
compute trailingSpaceRun also when text-align needs it.

The used value of text-align is saved in LineInfo to use later since it
is now computed earlier, and computing it is more than reading from
ComputedStyle.

Also turns soft-hyphen-4.html to a ref test.

BUG=660178
Review-Url: https://codereview.chromium.org/2786753002
Cr-Commit-Position: refs/heads/master@{#461018}
Committed: https://chromium.googlesource.com/chromium/src/+/1bdce8bacd54f2f8397939561e42822916c4fcb7

[kojii, 2017-03-29 18:25:22]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 18:26:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-29 18:36:09]

Description was changed from

==========
align

BUG=660178
==========

to

==========
Fix text-align: center/right when line wraps at atomic inline and spaces

LayoutBlockFlow::updateLogicalWidthForAlignment() requires
trailingSpaceRun to compute center/right alignment when line wraps at
atomic inline and spaces, but InlineBidiResolver computes
trailingSpaceRun only when UAX#9 L1 is needed. This patch fixes to
compute trailingSpaceRun in such cases.

Also, since text-align is computed earlier for this purpose, and it's
more than referring ComputedStyle to support text-align-last, its
computed value is saved in LineInfo to pass down to
updateLogicalWidthForAlignment().

BUG=660178
==========

[kojii, 2017-03-29 18:41:08]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-03-29 18:41:15]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-29 18:41:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 20:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 20:04:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-03-29 20:13:53]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 20:14:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 21:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:55:33]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2017-03-30 01:23:35]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 01:24:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-30 01:25:28]

Description was changed from

==========
Fix text-align: center/right when line wraps at atomic inline and spaces

LayoutBlockFlow::updateLogicalWidthForAlignment() requires
trailingSpaceRun to compute center/right alignment when line wraps at
atomic inline and spaces, but InlineBidiResolver computes
trailingSpaceRun only when UAX#9 L1 is needed. This patch fixes to
compute trailingSpaceRun in such cases.

Also, since text-align is computed earlier for this purpose, and it's
more than referring ComputedStyle to support text-align-last, its
computed value is saved in LineInfo to pass down to
updateLogicalWidthForAlignment().

BUG=660178
==========

to

==========
Fix text-align: center/right when line wraps at atomic inline and spaces

LayoutBlockFlow::updateLogicalWidthForAlignment() requires
trailingSpaceRun to compute center/right alignment when line wraps at
atomic inline and spaces, but InlineBidiResolver computes
trailingSpaceRun only when UAX#9 L1 is needed. This patch fixes to
compute trailingSpaceRun in such cases.

The used value of text-align is saved in LineInfo to use later since it
is now computed earlier, and computing it is more than reading from
ComputedStyle.

Also turns soft-hyphen-4.html to a ref test.

BUG=660178
==========

[kojii, 2017-03-30 01:31:54]

Description was changed from

==========
Fix text-align: center/right when line wraps at atomic inline and spaces

LayoutBlockFlow::updateLogicalWidthForAlignment() requires
trailingSpaceRun to compute center/right alignment when line wraps at
atomic inline and spaces, but InlineBidiResolver computes
trailingSpaceRun only when UAX#9 L1 is needed. This patch fixes to
compute trailingSpaceRun in such cases.

The used value of text-align is saved in LineInfo to use later since it
is now computed earlier, and computing it is more than reading from
ComputedStyle.

Also turns soft-hyphen-4.html to a ref test.

BUG=660178
==========

to

==========
Fix text-align: center/right when line wraps at atomic inline and spaces

LayoutBlockFlow::updateLogicalWidthForAlignment() requires
trailingSpaceRun to compute center/right alignment when line wraps at
atomic inline and spaces, but InlineBidiResolver computes
trailingSpaceRun only when UAX#9 L1 is needed. This patch fixes to
compute trailingSpaceRun also when text-align needs it.

The used value of text-align is saved in LineInfo to use later since it
is now computed earlier, and computing it is more than reading from
ComputedStyle.

Also turns soft-hyphen-4.html to a ref test.

BUG=660178
==========

[kojii, 2017-03-30 01:32:11]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-03-30 01:32:12]

PTAL.

[commit-bot: I haz the power, 2017-03-30 03:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 03:16:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[eae, 2017-03-30 19:04:46]

This is so much cleaner than my attempt to fix that bug, thank you!

LGTM

[eae, 2017-03-30 19:04:58]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-03-30 19:05:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 21:14:07]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kojii, 2017-03-31 00:50:57]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-03-31 00:52:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-31 01:55:34]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-03-31 01:55:34]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2786753002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-31 01:56:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 03:52:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490925334166160,
"parent_rev": "f73bd477a4ec4815ddae1e9878fc283f1ec5c98f", "commit_rev":
"1bdce8bacd54f2f8397939561e42822916c4fcb7"}

[commit-bot: I haz the power, 2017-03-31 03:53:46]

Description was changed from

==========
Fix text-align: center/right when line wraps at atomic inline and spaces

LayoutBlockFlow::updateLogicalWidthForAlignment() requires
trailingSpaceRun to compute center/right alignment when line wraps at
atomic inline and spaces, but InlineBidiResolver computes
trailingSpaceRun only when UAX#9 L1 is needed. This patch fixes to
compute trailingSpaceRun also when text-align needs it.

The used value of text-align is saved in LineInfo to use later since it
is now computed earlier, and computing it is more than reading from
ComputedStyle.

Also turns soft-hyphen-4.html to a ref test.

BUG=660178
==========

to

==========
Fix text-align: center/right when line wraps at atomic inline and spaces

LayoutBlockFlow::updateLogicalWidthForAlignment() requires
trailingSpaceRun to compute center/right alignment when line wraps at
atomic inline and spaces, but InlineBidiResolver computes
trailingSpaceRun only when UAX#9 L1 is needed. This patch fixes to
compute trailingSpaceRun also when text-align needs it.

The used value of text-align is saved in LineInfo to use later since it
is now computed earlier, and computing it is more than reading from
ComputedStyle.

Also turns soft-hyphen-4.html to a ref test.

BUG=660178

Review-Url: https://codereview.chromium.org/2786753002
Cr-Commit-Position: refs/heads/master@{#461018}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bdce8bacd54f2f8397939561e42...
==========

[commit-bot: I haz the power, 2017-03-31 03:53:47]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1bdce8bacd54f2f8397939561e42...