[Chromecast] Add Cast Assistant product type.

[Chromecast] Add Cast Assistant product type.

Bug: internal b/36447710
Change-Id: I5db3d8203d7c7369a48bff45cbaf582a673c57b6
Review-Url: https://codereview.chromium.org/2786723002
Cr-Commit-Position: refs/heads/master@{#460580}
Committed: https://chromium.googlesource.com/chromium/src/+/7c92b6eeffcffd078da1cca9a1d9dade8560ba4e

[gfhuang, 2017-03-29 17:34:42]

Description was changed from

==========
[Chromecast] Add Cast Assistant product type.

Bug: internal b/36447710
Change-Id: I5db3d8203d7c7369a48bff45cbaf582a673c57b6
==========

to

==========
[Chromecast] Add Cast Assistant product type.

Bug: internal b/36447710
Change-Id: I5db3d8203d7c7369a48bff45cbaf582a673c57b6
==========

[gfhuang, 2017-03-29 17:34:42]

gfhuang@chromium.org changed reviewers:
+ asvitkine@chromium.org, halliwell@chromium.org, slan@chromium.org

[Alexei Svitkine (slow), 2017-03-29 17:42:31]

lgtm

[halliwell, 2017-03-29 19:24:05]

On 2017/03/29 17:42:31, Alexei Svitkine (slow) wrote:
> lgtm

lgtm

[slan, 2017-03-29 19:29:18]

lgtm, per offline conversation.

https://codereview.chromium.org/2786723002/diff/1/chromecast/base/BUILD.gn
File chromecast/base/BUILD.gn (right):

https://codereview.chromium.org/2786723002/diff/1/chromecast/base/BUILD.gn#ne...
chromecast/base/BUILD.gn:26: assert(cast_product_type >= 0 && cast_product_type
<= 5)
nit: This should technically be:
  assert((type >= 0  && type <= 3) || type == 5)

[gfhuang, 2017-03-29 21:03:23]

The CQ bit was checked by gfhuang@chromium.org

[gfhuang, 2017-03-29 21:03:30]

The CQ bit was unchecked by gfhuang@chromium.org

[gfhuang, 2017-03-29 21:03:46]

The CQ bit was checked by gfhuang@chromium.org

[gfhuang, 2017-03-29 21:04:06]

On 2017/03/29 19:29:18, slan wrote:
> lgtm, per offline conversation.
> 
> https://codereview.chromium.org/2786723002/diff/1/chromecast/base/BUILD.gn
> File chromecast/base/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2786723002/diff/1/chromecast/base/BUILD.gn#ne...
> chromecast/base/BUILD.gn:26: assert(cast_product_type >= 0 &&
cast_product_type
> <= 5)
> nit: This should technically be:
>   assert((type >= 0  && type <= 3) || type == 5)

This likely doesn't matter that much in practical.

[gfhuang, 2017-03-29 21:04:13]

The CQ bit was unchecked by gfhuang@chromium.org

[gfhuang, 2017-03-29 21:07:21]

The CQ bit was checked by gfhuang@chromium.org

[gfhuang, 2017-03-29 21:07:21]

The patchset sent to the CQ was uploaded after l-g-t-m from slan@chromium.org,
asvitkine@chromium.org, halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2786723002/#ps20001
(title: "[Chromecast] Add Cast Assistant product type.")

[gfhuang, 2017-03-29 21:07:28]

On 2017/03/29 21:04:06, gfhuang wrote:
> On 2017/03/29 19:29:18, slan wrote:
> > lgtm, per offline conversation.
> > 
> > https://codereview.chromium.org/2786723002/diff/1/chromecast/base/BUILD.gn
> > File chromecast/base/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2786723002/diff/1/chromecast/base/BUILD.gn#ne...
> > chromecast/base/BUILD.gn:26: assert(cast_product_type >= 0 &&
> cast_product_type
> > <= 5)
> > nit: This should technically be:
> >   assert((type >= 0  && type <= 3) || type == 5)
> 
> This likely doesn't matter that much in practical.

done.

[commit-bot: I haz the power, 2017-03-29 21:07:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 23:44:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490821641439960,
"parent_rev": "87569a5ed05e1e4c04625819bad26ba0a232b0c3", "commit_rev":
"7c92b6eeffcffd078da1cca9a1d9dade8560ba4e"}

[commit-bot: I haz the power, 2017-03-29 23:45:19]

Description was changed from

==========
[Chromecast] Add Cast Assistant product type.

Bug: internal b/36447710
Change-Id: I5db3d8203d7c7369a48bff45cbaf582a673c57b6
==========

to

==========
[Chromecast] Add Cast Assistant product type.

Bug: internal b/36447710
Change-Id: I5db3d8203d7c7369a48bff45cbaf582a673c57b6
Review-Url: https://codereview.chromium.org/2786723002
Cr-Commit-Position: refs/heads/master@{#460580}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c92b6eeffcffd078da1cca9a1d9...
==========

[commit-bot: I haz the power, 2017-03-29 23:45:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c92b6eeffcffd078da1cca9a1d9...