Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2786713002: scheduler: Use a non-empty tracing category in test (Closed)

Created:
3 years, 8 months ago by Sami
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Use a non-empty tracing category in test BUG=706416 TBR=primiano@chromium.org Review-Url: https://codereview.chromium.org/2786713002 Cr-Commit-Position: refs/heads/master@{#460484} Committed: https://chromium.googlesource.com/chromium/src/+/20b661f1dffc812e1432ce1d506cc367ad5c24eb

Patch Set 1 #

Patch Set 2 : Fix all the categories #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
3 years, 8 months ago (2017-03-29 17:31:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786713002/20001
3 years, 8 months ago (2017-03-29 17:31:38 UTC) #5
Primiano Tucci (use gerrit)
LGTM but is there any reason why the category name is dynamic? That is quite ...
3 years, 8 months ago (2017-03-29 17:33:38 UTC) #6
Sami
On 2017/03/29 17:33:38, Primiano Tucci wrote: > LGTM but is there any reason why the ...
3 years, 8 months ago (2017-03-29 17:55:13 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:22:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/20b661f1dffc812e1432ce1d506c...

Powered by Google App Engine
This is Rietveld 408576698