Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2786703004: Gtk3: Fix DCHECK on 3.20 (Closed)

Created:
3 years, 8 months ago by Tom (Use chromium acct)
Modified:
3 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Fix DCHECK on 3.20 BUG=79722 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2786703004 Cr-Commit-Position: refs/heads/master@{#460838} Committed: https://chromium.googlesource.com/chromium/src/+/36743fca967c5b9d7ae91c210c49987fe0e9882b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Tom (Use chromium acct)
3 years, 8 months ago (2017-03-29 23:36:32 UTC) #2
Elliot Glaysher
lgtm, but are you sure you used the right bug number? You included the one ...
3 years, 8 months ago (2017-03-29 23:46:28 UTC) #4
Tom (Use chromium acct)
On 2017/03/29 23:46:28, Elliot Glaysher wrote: > lgtm, but are you sure you used the ...
3 years, 8 months ago (2017-03-30 00:00:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786703004/1
3 years, 8 months ago (2017-03-30 18:44:05 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 18:57:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36743fca967c5b9d7ae91c210c49...

Powered by Google App Engine
This is Rietveld 408576698