Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chrome/browser/ui/views/toolbar/reload_button_unittest.cc

Issue 2786693002: Add PointerDetails to ui::MouseEvent's constructors (Closed)
Patch Set: mouse event constructor Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/reload_button_unittest.cc
diff --git a/chrome/browser/ui/views/toolbar/reload_button_unittest.cc b/chrome/browser/ui/views/toolbar/reload_button_unittest.cc
index 00195421212e384e82bddb7f043ae78a9570e759..9f419ba042be4841ac54cb66d1dec8a632369c8a 100644
--- a/chrome/browser/ui/views/toolbar/reload_button_unittest.cc
+++ b/chrome/browser/ui/views/toolbar/reload_button_unittest.cc
@@ -65,8 +65,9 @@ TEST_F(ReloadButtonTest, Basic) {
false);
// Press the button. This should start the double-click timer.
- ui::MouseEvent e(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), 0, 0);
+ ui::MouseEvent e(
+ ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),
+ 0, 0, ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));
reload()->ButtonPressed(reload(), e);
CheckState(true, ReloadButton::MODE_RELOAD, ReloadButton::MODE_RELOAD, true,
false);
@@ -85,8 +86,9 @@ TEST_F(ReloadButtonTest, Basic) {
TEST_F(ReloadButtonTest, DoubleClickTimer) {
// Start by pressing the button.
- ui::MouseEvent e(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), 0, 0);
+ ui::MouseEvent e(
+ ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),
+ 0, 0, ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));
reload()->ButtonPressed(reload(), e);
// Try to press the button again. This should do nothing because the timer is
@@ -112,8 +114,9 @@ TEST_F(ReloadButtonTest, DoubleClickTimer) {
TEST_F(ReloadButtonTest, DisableOnHover) {
// Change to stop and hover.
- ui::MouseEvent e(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), 0, 0);
+ ui::MouseEvent e(
+ ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),
+ 0, 0, ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));
reload()->ButtonPressed(reload(), e);
reload()->ChangeMode(ReloadButton::MODE_STOP, false);
set_mouse_hovered(true);
@@ -126,8 +129,9 @@ TEST_F(ReloadButtonTest, DisableOnHover) {
// Un-hover the button, which should allow it to reset.
set_mouse_hovered(false);
- ui::MouseEvent e2(ui::ET_MOUSE_MOVED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), 0, 0);
+ ui::MouseEvent e2(
+ ui::ET_MOUSE_MOVED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(), 0,
+ 0, ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));
reload()->OnMouseExited(e2);
CheckState(true, ReloadButton::MODE_RELOAD, ReloadButton::MODE_RELOAD, false,
false);
@@ -135,8 +139,9 @@ TEST_F(ReloadButtonTest, DisableOnHover) {
TEST_F(ReloadButtonTest, ResetOnClick) {
// Change to stop and hover.
- ui::MouseEvent e(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), 0, 0);
+ ui::MouseEvent e(
+ ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),
+ 0, 0, ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));
reload()->ButtonPressed(reload(), e);
reload()->ChangeMode(ReloadButton::MODE_STOP, false);
set_mouse_hovered(true);
@@ -150,8 +155,9 @@ TEST_F(ReloadButtonTest, ResetOnClick) {
TEST_F(ReloadButtonTest, ResetOnTimer) {
// Change to stop, hover, and change back to reload.
- ui::MouseEvent e(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), 0, 0);
+ ui::MouseEvent e(
+ ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),
+ 0, 0, ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));
reload()->ButtonPressed(reload(), e);
reload()->ChangeMode(ReloadButton::MODE_STOP, false);
set_mouse_hovered(true);

Powered by Google App Engine
This is Rietveld 408576698