chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc - Issue 2786693002: Add PointerDetails to ui::MouseEvent's constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc

Issue 2786693002: Add PointerDetails to ui::MouseEvent's constructors (Closed)

Patch Set: mouse event constructor Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc ('k') | chrome/browser/ui/views/find_bar_views_interactive_uitest.cc » ('j') | ui/events/event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc b/chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc

index f4221a93d3515e613880531139963df1058dc2c3..0bf10e7523a2ee5d4e3604404d8dd0e78d4acc6a 100644

--- a/chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc

@@ -53,10 +53,12 @@ IN_PROC_BROWSER_TEST_F(BookmarkOverrideTest, DISABLED_NonOverrideStarClick) {

ui::MouseEvent pressed_event(

ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),

- ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON);

+ ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON,

+ ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));

ui::MouseEvent released_event(

ui::ET_MOUSE_RELEASED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),

- ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON);

+ ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON,

+ ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));

// Verify that clicking once shows the bookmark bubble.

EXPECT_FALSE(BookmarkBubbleView::bookmark_bubble());