chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc - Issue 2786693002: Add PointerDetails to ui::MouseEvent's constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

Issue 2786693002: Add PointerDetails to ui::MouseEvent's constructors (Closed)

Patch Set: mouse event constructor Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/password_generation_popup_view_tester_views.cc ('k') | chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc » ('j') | ui/events/event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

index 7238e8e0713fabeeb88a4942c1645e336fc8f0f6..9633a1ecfe1486f827c4fb26100c40aa31fdf682 100644

--- a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

@@ -150,8 +150,10 @@ TEST_F(DesktopMediaPickerViewsTest, SelectMediaSourceViewOnSingleClick) {

EXPECT_FALSE(source_view_1->is_selected());

// Source view 0 is selected with mouse click.

- ui::MouseEvent press(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),

- ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON, 0);

+ ui::MouseEvent press(

+ ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),

+ ui::EF_LEFT_MOUSE_BUTTON, 0,

+ ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));

GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnMousePressed(

press);

@@ -178,10 +180,11 @@ TEST_F(DesktopMediaPickerViewsTest, DoneCallbackCalledOnDoubleClick) {

EXPECT_TRUE(ClickSourceTypeButton(DesktopMediaID::TYPE_WEB_CONTENTS));

GetPickerDialogView()->GetCheckboxForTesting()->SetChecked(false);

- ui::MouseEvent double_click(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),

- ui::EventTimeForNow(),

- ui::EF_LEFT_MOUSE_BUTTON | ui::EF_IS_DOUBLE_CLICK,

- ui::EF_LEFT_MOUSE_BUTTON);

+ ui::MouseEvent double_click(

+ ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), ui::EventTimeForNow(),

+ ui::EF_LEFT_MOUSE_BUTTON | ui::EF_IS_DOUBLE_CLICK,

+ ui::EF_LEFT_MOUSE_BUTTON,

+ ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE));

GetPickerDialogView()->GetMediaSourceViewForTesting(0)->OnMousePressed(

double_click);