Add PointerDetails to ui::MouseEvent's constructors

Add PointerDetails to ui::MouseEvent's constructors

We should put all the MouseEvent's properties in PointerDetails class, so add a PointerDetails object
in ui::MouseEvent's constructors.

BUG=699372
Review-Url: https://codereview.chromium.org/2786693002
Cr-Commit-Position: refs/heads/master@{#464201}
Committed: https://chromium.googlesource.com/chromium/src/+/3e727d61336a80e47949951d2d71aa506e90d774

[lanwei, 2017-03-29 16:32:01]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:33:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-03-29 16:34:31]

Description was changed from

==========
mouse event constructor

BUG=
==========

to

==========
Add PointerDetails to ui::MouseEvent's constructors

We should put all the MouseEvent's properties in PointerDetails class, so add a
PointerDetails object in ui::MouseEvent's constructors.

BUG=699372
==========

[lanwei, 2017-03-29 16:34:31]

lanwei@chromium.org changed reviewers:
+ sadrul@chromium.org

[lanwei, 2017-03-29 16:35:17]

Description was changed from

==========
Add PointerDetails to ui::MouseEvent's constructors

We should put all the MouseEvent's properties in PointerDetails class, so add a
PointerDetails object in ui::MouseEvent's constructors.

BUG=699372
==========

to

==========
Add PointerDetails to ui::MouseEvent's constructors

We should put all the MouseEvent's properties in PointerDetails class, so add a
PointerDetails object
in ui::MouseEvent's constructors.

BUG=699372
==========

[commit-bot: I haz the power, 2017-03-29 16:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:44:18]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[lanwei, 2017-03-29 16:59:33]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 17:00:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:13:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lanwei, 2017-03-29 17:25:08]

Patchset #1 (id:1) has been deleted

[lanwei, 2017-03-29 17:26:32]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 17:26:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:55:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:55:14]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lanwei, 2017-03-29 18:05:06]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 18:05:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 18:25:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lanwei, 2017-03-29 20:34:21]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 20:34:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 21:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:05:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lanwei, 2017-03-29 21:11:17]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 21:11:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-03-29 21:13:48]

Patchset #1 (id:20001) has been deleted

[lanwei, 2017-03-29 21:14:03]

Patchset #1 (id:40001) has been deleted

[lanwei, 2017-03-29 21:14:20]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-03-29 21:40:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:40:04]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lanwei, 2017-03-29 21:53:32]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[lanwei, 2017-03-29 21:54:14]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-03-29 21:54:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-03-30 01:43:54]

The CQ bit was unchecked by lanwei@chromium.org

[lanwei, 2017-03-30 01:44:58]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 01:45:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 02:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 02:06:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[lanwei, 2017-03-30 15:43:18]

Patchset #1 (id:100001) has been deleted

[sadrul, 2017-04-04 03:47:15]

https://codereview.chromium.org/2786693002/diff/120001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2786693002/diff/120001/ui/events/event.h#newc...
ui/events/event.h:523: const PointerDetails& pointer_details);
Most (all) users of this ctor simply pass in the default
PointerDetails(POINTER_TYPE_MOUSE) or PointerDetails(POINTER_TYPE_MOUSE,
kMousePointerId). Can we use the latter as the default argument here, so that
all the callsites don't need to do this explicitly?

Is there any callsite where some other attributes are set on the PointerDetails?

[lanwei, 2017-04-04 20:11:57]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 20:12:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 21:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 21:35:56]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-04-10 18:10:06]

Sorry about the review delay. lgtm Thanks a lot for the cleanup!

https://codereview.chromium.org/2786693002/diff/140001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/2786693002/diff/140001/ui/events/event.h#newc...
ui/events/event.h:527: kMousePointerId));
I was a bit worried about the lifetime of the object in the default-param. But
according to internet [1], this should be safe.

[1] http://stackoverflow.com/questions/14612933/const-reference-default-value

[lanwei, 2017-04-10 19:42:11]

lanwei@chromium.org changed reviewers:
+ brettw@chromium.org, dcheng@chromium.org

[lanwei, 2017-04-10 19:44:03]

brettw@ could you please take a look at all the files under
content/, services/,

dcheng@ could you please take a look at ui/events/mojo/event_struct_traits.cc,

thank you?

[dcheng, 2017-04-11 00:38:26]

rs lgtm for struct traits changes

[brettw, 2017-04-12 17:46:19]

lgtm

[lanwei, 2017-04-12 17:47:19]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:48:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:51:36]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lanwei, 2017-04-12 18:18:47]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2017-04-12 18:18:47]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
sadrul@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2786693002/#ps160001
(title: "rebase master")

[commit-bot: I haz the power, 2017-04-12 18:19:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 18:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 18:34:31]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lanwei, 2017-04-12 19:52:21]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 19:53:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 21:19:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:19:15]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-04-12 21:19:58]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2017-04-12 21:19:58]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
sadrul@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2786693002/#ps180001
(title: "mouse constructor")

[lanwei, 2017-04-12 21:20:25]

Patchset #3 (id:160001) has been deleted

[commit-bot: I haz the power, 2017-04-12 21:20:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:19:35]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1492031998081950,
"parent_rev": "6f6800ef881708032eca27154bb6740c41dd7357", "commit_rev":
"3e727d61336a80e47949951d2d71aa506e90d774"}

[commit-bot: I haz the power, 2017-04-12 23:20:26]

Description was changed from

==========
Add PointerDetails to ui::MouseEvent's constructors

We should put all the MouseEvent's properties in PointerDetails class, so add a
PointerDetails object
in ui::MouseEvent's constructors.

BUG=699372
==========

to

==========
Add PointerDetails to ui::MouseEvent's constructors

We should put all the MouseEvent's properties in PointerDetails class, so add a
PointerDetails object
in ui::MouseEvent's constructors.

BUG=699372

Review-Url: https://codereview.chromium.org/2786693002
Cr-Commit-Position: refs/heads/master@{#464201}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e727d61336a80e47949951d2d71...
==========

[commit-bot: I haz the power, 2017-04-12 23:20:30]

Committed patchset #3 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/3e727d61336a80e47949951d2d71...